Date: Tue, 4 Feb 2020 15:00:53 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: freebsd-x11@FreeBSD.org Subject: Re: X11 + i915kms Message-ID: <6672cfbf-17b0-8480-0da1-1a6ec2f1d6ea@selasky.org> In-Reply-To: <a75y-ttu1-wny@FreeBSD.org> References: <abff058c-795c-ed85-65a6-ee2d440817a2@selasky.org> <d0ca-58eq-wny@FreeBSD.org> <a8e02116-6f8c-947e-93a3-3d75411f9aec@selasky.org> <a75y-ttu1-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2020-02-04 13:33, Jan Beich wrote: > Hans Petter Selasky <hps@selasky.org> writes: > >> On 2019-12-27 12:12, Jan Beich wrote: >> >>> Hans Petter Selasky <hps@selasky.org> writes: >>> >>>> Hi, >>>> >>>> Just did a fresh install of X11 and stuff. I noticed the >>>> xf86-video-intel is very sluggish unless SNA acceleration mode is >>>> selected. Do you know anything about this? Maybe make it the default? >>>> Or should I have used another driver? >>> FreeBSD disabled SNA by default for compatibility with >>> pre-SandyBridge >>> on drm-legacy-kmod (previously, in-base drm2), see bug 214593. >>> SNA is also unstable due to I915_USERPTR_UNSYNCHRONIZED, so you may >>> need the patch in bug 236003. >> >> Does this fix the issue? >> https://github.com/FreeBSDDesktop/kms-drm/pull/205 > > Yes but it needs to be applied to drm-v4.11 and drm-v4.16 as well. > drm-v4.9 works fine as is. I've originally reported the issue > in https://github.com/FreeBSDDesktop/kms-drm/issues/32. > > However, the way you've handled LinuxKPI changes won't help on already > released FreeBSD versions e.g., > > graphics/drm-fbsd12.0-kmod on FreeBSD 12.1: > drivers/gpu/drm/i915/i915_gem_userptr.c:514:7: error: implicit declaration of function 'mmget_not_zero' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > if (mmget_not_zero(mm)) { > ^ > drivers/gpu/drm/i915/i915_gem_userptr.c:514:7: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] > > graphics/drm-fbsd11.2-kmod on FreeBSD 11.3: > i915_gem_userptr.c:511:7: error: implicit declaration of function 'mmget_not_zero' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > if (mmget_not_zero(mm)) { > ^ > i915_gem_userptr.c:511:7: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] > I can MFC to the release branch too if that helps. Do you know which branch you are using for 11 and 12 ports? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6672cfbf-17b0-8480-0da1-1a6ec2f1d6ea>