Date: Mon, 5 Nov 2007 13:40:59 +0200 From: Peter Pentchev <roam@ringlet.net> To: Doug Barton <dougb@FreeBSD.org> Cc: freebsd-ports@freebsd.org Subject: Re: 'make -DNO_DEPENDS install' causing error Message-ID: <20071105114059.GA1202@straylight.m.ringlet.net> In-Reply-To: <alpine.BSF.0.9999.0710310942060.57165@qbhto.arg> References: <alpine.BSF.0.9999.0710301318110.33134@ync.qbhto.arg> <20071031151850.GA1145@straylight.m.ringlet.net> <alpine.BSF.0.9999.0710310919530.57165@qbhto.arg> <20071031163049.GB1145@straylight.m.ringlet.net> <alpine.BSF.0.9999.0710310942060.57165@qbhto.arg>
next in thread | previous in thread | raw e-mail | index | archive | help
--9jxsPFA5p3P2qPhR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Oct 31, 2007 at 09:44:13AM -0700, Doug Barton wrote:
> On Wed, 31 Oct 2007, Peter Pentchev wrote:
>=20
>> On Wed, Oct 31, 2007 at 09:21:54AM -0700, Doug Barton wrote:
>>> On Wed, 31 Oct 2007, Peter Pentchev wrote:
>>>=20
>>>> Errr... maybe I should actually take a careful look at portmaster firs=
t,
>>>> but after a cursory look at portmaster.sh.in... how do you handle the
>>>> case of a port installation that executes commands from a runtime
>>>> dependency? That is, a runtime dependency that is actually used at
>>>> install time, too?
>>>=20
>>> That should be a build dependency then. I'll take a look at the example=
=20
>>> you
>>> cited, but my gut feeling is that what you're describing shouldn't=20
>>> happen.
>>=20
>> Erm, nope... A build dependency is not meant to modify anything
>> on the user's system,
>=20
> Except building the new port of course. :)
Well, sure :) I should have mentioned "not meant to modify anything
in ${PREFIX}" - and, of course, this does not cover the case when
${WKRDIRPREFIX} is within ${PREFIX}, but that's a whole 'nuther kettle
of fish there :)
>> but the installation process may need to, say, rebuild indexes or=20
>> otherwise update some kind of configuration. Think add-on packages - som=
e=20
>> of them might need some kind of registration in the main package's=20
>> configuration.
>>=20
>> At least that's the way I see it, and ICBW, but I think that there are
>> various legitimate cases when a run-time dependency ought to be installed
>> before the package installation itself.
>=20
> I guess what I'm getting at is that (as far as I can see) that's not what=
=20
> happens now. The parent port is installed first, then run depends are=20
> checked. But like I said, I'll take a look at your original example, and=
=20
> those below.
Errrr... do you mean that's what happens now in the ports collection,
when a "make install" is issued in a directory with a Makefile which
includes bsd.port.mk?! 'Cause, you know, that's just... not true :)
You could either check it yourself, by running "make install" in
a port directory and looking at the sequence of actions :) Or you could
check the _INSTALL_SEQ and _INSTALL_SUSEQ variables in bsd.port.mk around
line 4117 - "run-depends" is in _INSTALL_SEQ, "do-install" is in
_INSTALL_SUSEQ, and bsd.port.mk runs the _SEQ targets before _SUSEQ
(bsd.port.mk around line 4176 for the normal case and 4161-4167 for
the su-use case).
The Ports Collection as such processes the runtime dependencies before
actually running the port's install target.
>> For more examples, take a look at the plist of most X11 fonts (@exec=20
>> fc-cache), most JDK implementations (@exec registervm), most docbook-*=
=20
>> ports (@exec xmlcatmgr), some GNOME ports like gnomevfs (@exec=20
>> gconftool-2), and many others.
G'luck,
Peter
--=20
Peter Pentchev roam@ringlet.net roam@cnsys.bg roam@FreeBSD.org
PGP key: http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553
This sentence is false.
--9jxsPFA5p3P2qPhR
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (FreeBSD)
iD8DBQFHLwFL7Ri2jRYZRVMRAljaAKCVqCEb8z+3eInMXmBTp0wO9JQC4QCfai78
VMOPi6ilUaOkMyrYLOSv9wc=
=48Oh
-----END PGP SIGNATURE-----
--9jxsPFA5p3P2qPhR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071105114059.GA1202>