Date: Fri, 8 Mar 2013 21:42:58 +0000 From: Chris Rees <crees@FreeBSD.org> To: Warren Block <wblock@wonkity.com> Cc: freebsd-fs@freebsd.org, Brooks Davis <brooks@freebsd.org> Subject: Re: Argument list too long Message-ID: <CADLo838hgKciKpDTFtjguu-YUmxH7cb_1=KXM6bb%2B3qgtf784w@mail.gmail.com> In-Reply-To: <alpine.BSF.2.00.1303081239450.89649@wonkity.com> References: <82112.1362671436.13776555968178880512@ffe17.ukr.net> <20130307161546.GV47829@e-new.0x20.net> <20130308190917.GA34838@lor.one-eyed-alien.net> <alpine.BSF.2.00.1303081239450.89649@wonkity.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8 Mar 2013 20:05, "Warren Block" <wblock@wonkity.com> wrote: > > On Fri, 8 Mar 2013, Brooks Davis wrote: > >> On Thu, Mar 07, 2013 at 05:15:46PM +0100, Lars Engels wrote: >>> >>> On Thu, Mar 07, 2013 at 05:50:36PM +0200, Vladislav Prodan wrote: >>>> >>>> Why 12K small files from one directory to cause problems? >>>> >>>> # ll | wc -l >>>> 11467 >>>> >>>> # grep X-PHP-Script * | more >>>> /sbin/grep: Argument list too long. >>>> >>>> # egrep X-PHP-Script *.ua | more >>>> /usr/sbin/egrep: Argument list too long. >>>> >>>> # cat *.ua | grep X-PHP-Script | more >>>> /sbin/cat: Argument list too long. >>>> >>>> >>>> >>> >>> Your shell can't process that many arguments. Use this: >>> >>> grep -R "X-PHP-Script" . >>> >>> or if you don't want to descent into subdirectories: >>> >>> find . -type -f -name '*.ua' -maxdepth 1 -exec grep "X-PHP-Script" {} \+ > > > There is a typo, should be "-type f". > > >> This won't include file names and is gratuitously inefficient starting one >> grep per file. > > > But the final \+ means "{} is replaced with as many pathnames as possible for each invocation of utility. This behaviour is similar to that of xargs(1)." > > >> The command you're looking for is: >> >> find . -type -f -name '*.ua' -maxdepth 1 -print0 | xargs -0 grep -H "X-PHP-Script" >> >> The find -print0 | xargs -0 allows filenames to contain spaces. The >> grep -H is mostly theoretical in that the last grep invocation by xargs >> couple only include one file and thus wouldn't include the filename. > > > For fun, after running each of these several times to preload cache: > > find /usr/ports -type f -print0 | xargs -0 grep -H "X-PHP-Script" > 40.98 seconds (average) > > find /usr/ports -type f -exec grep -H "X-PHP-Script" {} \+ > 42.27 seconds (average) > > So they aren't too different in performance. The \+ form I have also found impossible to achieve in csh, which is why I never recommend it. Chris (Rees not Ross :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo838hgKciKpDTFtjguu-YUmxH7cb_1=KXM6bb%2B3qgtf784w>