Date: Sun, 30 Jul 2006 22:02:50 +0200 From: Tijl Coosemans <tijl@ulyssis.org> To: kmacy@fsmware.com Cc: freebsd-hackers@freebsd.org Subject: Re: i386 page fault clobbers error code in trap frame Message-ID: <200607302202.54315.tijl@ulyssis.org> In-Reply-To: <b1fa29170607301230u65548684ud25d77e0ff0bfb96@mail.gmail.com> References: <200607292110.37733.tijl@ulyssis.org> <200607301834.16657.tijl@ulyssis.org> <b1fa29170607301230u65548684ud25d77e0ff0bfb96@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart2788921.PdlsaWxk3Z Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday 30 July 2006 21:30, Kip Macy wrote: > > si_addr doesn't contain the faulting pc, it contains the address > > that > > So either the comment is wrong, or that is a technically incorrect > kludge. However, given that a number of the other fields are not > filled out at all, the real objective should be to keep applications > working. Well, the comment is correct except in case of a page fault. But this is=20 different from stable. In stable si_addr is a copy of tf_err, which,=20 because of the kludge, holds the fault address in case of a page=20 fault... I'm glad to see this code has been cleaned up. --nextPart2788921.PdlsaWxk3Z Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQBEzRBudMR2xnarec8RAmj6AJ9u2EP4NlScRtKMU7LiScozggiSkwCdG4EH bqfg49dxTUj5GCpTqcYpYJs= =WqkR -----END PGP SIGNATURE----- --nextPart2788921.PdlsaWxk3Z--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607302202.54315.tijl>