Date: Mon, 18 Jan 2016 13:15:22 +0100 From: "Ronald Klop" <ronald-lists@klop.ws> To: freebsd-fs@freebsd.org Subject: Re: [Bug 206328] Crash on shutdown with swap on NFS file (with patch) Message-ID: <op.ybfobwktkndu52@ronaldradial.radialsg.local> In-Reply-To: <bug-206328-3630-prHGdYMqZV@https.bugs.freebsd.org/bugzilla/> References: <bug-206328-3630@https.bugs.freebsd.org/bugzilla/> <bug-206328-3630-prHGdYMqZV@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 18 Jan 2016 10:48:10 +0100, <bugzilla-noreply@freebsd.org> wrote: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206328 > > --- Comment #3 from Tom Vijlbrief <tvijlbrief@gmail.com> --- > bufshutdown() ends with: > > > if (panicstr == NULL) > vfs_unmountall(); > } > swapoff_all(); > > Why not just reverse the order? > > So swapoff_all() before the vfs_unmountall(), so that the NFS filesystem > is > still available. > > Perhaps even at the start of bufshutdown(). > > Still wondering what the reason of a swapoff_all() call just before the > actual > reboot is. > Maybe... leaving swap on a mirrored disk will give a rebuild of the mirror on boot if swap is not swapped off.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.ybfobwktkndu52>