Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Feb 2017 20:34:14 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 217322] [NEW PORT] devel/fifechan : fifengine's team fork guichan
Message-ID:  <bug-217322-13-SqwDqvpFxM@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-217322-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-217322-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217322

Tobias Kortkamp <tobik@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
                 CC|                            |tobik@freebsd.org
           Assignee|freebsd-ports-bugs@FreeBSD. |tobik@freebsd.org
                   |org                         |

--- Comment #1 from Tobias Kortkamp <tobik@freebsd.org> ---
Thanks for your submission.  Some comments:

- Please use USE_GITHUB, GH_PROJECT, etc. (see
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile=
-distfiles.html#makefile-master_sites-github-description)
instead of setting MASTER_SITES and DISTFILES

- Please only indent with 1 tab after variables

- What do the SHARED_* variables do?

- The pkg-descr could be a little more detailed.  Currently it's basically =
the
same as the COMMENT

- Have you done any test building with Poudriere or Synth?

- What does portlint say about the port?

- What is the purpose of plist.sdlc?

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-217322-13-SqwDqvpFxM>