Date: Wed, 05 Jul 2017 16:13:57 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 220361] [MAINTAINER] [PATCH] textproc/ripgrep: Add Bash, Fish and Zsh completions Message-ID: <bug-220361-13-abxpuVU0LH@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-220361-13@https.bugs.freebsd.org/bugzilla/> References: <bug-220361-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220361 Tobias Kortkamp <tobik@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tobik@freebsd.org Status|New |Open Assignee|freebsd-ports-bugs@FreeBSD. |tobik@freebsd.org |org | --- Comment #1 from Tobias Kortkamp <tobik@freebsd.org> --- Yes, completion files would be great :) A couple of nitpicks below. I added the Unlicense to bsd.licenses.db.mk in ports r445082 which means your patch does not currently apply anymore. The license block can now be simplified to: LICENSE=3D MIT UNLICENSE LICENSE_COMB=3D dual LICENSE_FILE=3D ${WRKSRC}/COPYING LICENSE_FILE_MIT=3D ${WRKSRC}/LICENSE-MIT LICENSE_FILE_UNLICENSE=3D ${WRKSRC}/UNLICENSE +.include <bsd.port.options.mk> Please remove this again. It's not needed if you replace all `.if ${PORT_OPTIONS:MXXX}` with extra targets like post-install-XXX-on. See [1]. ${WRKDIR}/target/release/build/ripgrep-*/out should be changed to ${CARGO_TARGET_DIR}/*/build/ripgrep-*/out since it might not be 'release' but 'debug' when you compile the port WITH_DEBUG=3Dyes. Is there maybe a way to coerce the build to output the completion files to another directory? [1] https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html= #options-targets --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-220361-13-abxpuVU0LH>