Date: Mon, 31 Aug 2009 16:42:50 -0400 From: John Baldwin <jhb@freebsd.org> To: Andrew Brampton <brampton+freebsd-hackers@gmail.com> Cc: jfv@freebsd.org, freebsd-hackers@freebsd.org Subject: Re: netstat -i Ierrs column, Is it total, or per second? Message-ID: <200908311642.50866.jhb@freebsd.org> In-Reply-To: <d41814900908311215o24cbded5y4c8dcb14ece5f670@mail.gmail.com> References: <d41814900908310318n113867dsf9e47f149b0e61b4@mail.gmail.com> <200908310804.27417.jhb@freebsd.org> <d41814900908311215o24cbded5y4c8dcb14ece5f670@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 31 August 2009 3:15:53 pm Andrew Brampton wrote: > 2009/8/31 John Baldwin <jhb@freebsd.org>: > > It should be total and it sounds like a bug in the device driver. =A0It= =20 looks > > like ixgbe_update_stats_counters() overwrites the accumulated value of > > if_ierrors: > > > > =A0 =A0 =A0 =A0/* Rx Errors */ > > =A0 =A0 =A0 =A0ifp->if_ierrors =3D total_missed_rx + adapter->stats.crc= errs + > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0adapter->stats.rlec; > > > > It also increments if_ierrors in ixgbe_rxeof(). =A0The driver should on= ly do=20 one > > or the other, but probably not both. > > > > -- > > John Baldwin > > >=20 > Thanks for your reply. I had wondered that, but looking at > e1000/if_em.c it does a similar thing. However, a quick look at > non-intel drivers and it seems others don't. So perhaps this is a > problem across the intel drivers? >=20 > So anyway I spent my afternoon reading the ixgbe spec sheet and > creating the attached patch, which hopefully fixes this problem. I > will forward this patch to freebsd <at> intel.com unless someone can > point me toward the maintainers email address, or should I just create > a PR? I cc'd him on my earlier reply (jfv@) so he should have seen your patch=20 already. =2D-=20 John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908311642.50866.jhb>