Date: Wed, 03 Jun 2009 11:03:45 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: rea-fbsd@codelabs.ru Cc: freebsd-hackers@FreeBSD.org, Jakub Lach <jakub_lach@mailplus.pl>, Bruce Evans <bde@zeta.org.au> Subject: Re: FYI Lighttpd 1.4.23 /kernel (trailing '/' on regular file symlink) vulnerability Message-ID: <86my8pelji.fsf@ds4.des.no> In-Reply-To: <dl%2BTldq1IjLtbwOv9fvp7D68xCc@10Ilc7MfiXA2JVIRVQpZfk7cTQ4> (Eygene Ryabinkin's message of "Wed, 3 Jun 2009 00:01:00 %2B0400") References: <23727599.post@talk.nabble.com> <86prdvipwe.fsf@ds4.des.no> <20090527233110.E4243@delplex.bde.org> <86r5yaijef.fsf@ds4.des.no> <20090529210855.V1643@besplex.bde.org> <86vdnju9z1.fsf@ds4.des.no> <86r5y7u9r3.fsf@ds4.des.no> <qlE9VS4n%2BoBC3U4EHMxYsjC7RHI@XX1fo6zQUfC4h0jjRC6IBz3oNH4> <86skiiri1p.fsf@ds4.des.no> <dl%2BTldq1IjLtbwOv9fvp7D68xCc@10Ilc7MfiXA2JVIRVQpZfk7cTQ4>
next in thread | previous in thread | raw e-mail | index | archive | help
Eygene Ryabinkin <rea-fbsd@codelabs.ru> writes: > "Dag-Erling Sm=C3=B8rgrav" <des@des.no> writes: > > Eygene Ryabinkin <rea-fbsd@codelabs.ru> writes: > > > Perhaps 'XXX for direnter()' should be changed to something like > > > 'strip trailing slashes in cnp->cn_nameptr'. > > I'll just remove it, since the previous comment clearly explains > > what is going on. > May be it's better to leave the comment, but replace it with more > undestandable one: this instruction is a bit tricky and it makes one to > think what the hell is going on. Isn't it clearly described in the preceding comment? Specifically, by the first two sentences: "Replace multiple slashes by a single slash and trailing slashes by a null. This must be done before VOP_LOOKUP() because some fs's don't know about trailing slashes." DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86my8pelji.fsf>