Date: Sat, 9 Oct 2021 18:20:56 -0300 From: "Danilo G. Baio" <dbaio@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: doc-committers@FreeBSD.org, dev-commits-doc-all@FreeBSD.org Subject: Re: git: 5a5db32f4a - main - Fix build after c8e8be58e580 Message-ID: <20211009212056.khm7yupqjbdb6agd@t480.local> In-Reply-To: <f1be4503-ae5b-450a-9174-98f145e44635@www.fastmail.com> References: <202110062359.196NxFqS079143@gitrepo.freebsd.org> <0595c299-55ed-17c4-74ac-16a804541473@FreeBSD.org> <20211007205425.j4idybl7jrtwxeal@t480.local> <ee5f8afe-af76-eda2-aefe-d3884f55f2cb@FreeBSD.org> <f1be4503-ae5b-450a-9174-98f145e44635@www.fastmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--aba3tildclchg73u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 07, 2021 at 06:59:44PM -0300, Danilo G. Baio wrote: >=20 >=20 > On Thu, Oct 7, 2021, at 18:20, John Baldwin wrote: > > On 10/7/21 1:54 PM, Danilo G. Baio wrote: > >> On Thu, Oct 07, 2021 at 09:22:56AM -0700, John Baldwin wrote: > >>> On 10/6/21 4:59 PM, Danilo G. Baio wrote: > >>>> The branch main has been updated by dbaio: > >>>> > >>>> URL: https://cgit.FreeBSD.org/doc/commit/?id=3D5a5db32f4a1e3f507cdc5= 5f92d53e63adbb4f022 > >>>> > >>>> commit 5a5db32f4a1e3f507cdc55f92d53e63adbb4f022 > >>>> Author: Danilo G. Baio <dbaio@FreeBSD.org> > >>>> AuthorDate: 2021-10-06 23:57:27 +0000 > >>>> Commit: Danilo G. Baio <dbaio@FreeBSD.org> > >>>> CommitDate: 2021-10-06 23:57:27 +0000 > >>>> > >>>> Fix build after c8e8be58e580 > >>> > >>> It used to be possible to use 'make' in individual books or articles = to test > >>> things, and also to only build just html versions and not be required= to > >>> build PDF. Apparently our new system doesn't permit either of those,= so I > >>> gave up on trying to test this pre-commit. > >>> > >>> --=20 > >>> John Baldwin > >>=20 > >>=20 > >> To speed up the build time (right now), you can build only English HTML > >> documentation this way: > >>=20 > >> $ cd documentation > >> $ DOC_LANG=3D"en" make > >>=20 > >> 14 seconds here > >> against 2 minutes for all languages. > >>=20 > >> The `make run` also helps as pointed by Sergio. > >>=20 > >>=20 > >> ps. PDF is not built automatically. > > > > I tried plain 'make' at the documentation top-level and it failed due t= o missing > > asciidoctor-pdf (I had built docproj with PDF unchecked). > > > > I have used 'make' just fine for the website in the past. The error me= ssage > > came from the 'requirements' target in documentation/Makefile: > > > > RUN_DEPENDS=3D ${PYTHON_CMD} \ > > ${HUGO_CMD} \ > > ${LOCALBASE}/bin/asciidoctor \ > > ${LOCALBASE}/bin/asciidoctor-pdf \ > > ${LOCALBASE}/bin/rougify > > > > ... > > > > all: requirements starting-message generate-books-toc=20 > > generate-pgpkeys-txt build > > run: requirements starting-message generate-books-toc=20 > > generate-pgpkeys-txt run-local > > > > ... > > > > requirements: > > .for dep in ${RUN_DEPENDS} > > .if !exists(${dep}) > > @(echo ${dep} not found, please run 'pkg install docproj=20 > > python3'; exit 1) > > .endif > > .endfor > > > > Thus, even using 'make html' or 'make run' will fail if the PDF tools= =20 > > aren't installed > > even though those make targets don't generate PDF. > > > > The problem for me wasn't the build time, it was the explicit error and= =20 > > exit above. > > > > --=20 > > John Baldwin >=20 > ah got it. >=20 > I misunderstood the main issue.=20 >=20 > we need to fix this requirement.=20 >=20 > and thanks for pointing that out. I've just changed the requirements. https://cgit.freebsd.org/doc/commit/?id=3D151b473480373cea7cdc1af86a1e78379= 76429a1 Thank you! --=20 Danilo G. Baio (dbaio) --aba3tildclchg73u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEORj0UTsjzCy+enIkmpN7LfMuiNcFAmFiB7VfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDM5 MThGNDUxM0IyM0NDMkNCRTdBNzIyNDlBOTM3QjJERjMyRTg4RDcACgkQmpN7LfMu iNeznxAApQXZNcw7Mz1+g7A4OesvibcgwlxKve9tTco8Wm347kc6KUjoxifNp+HZ dh+Yfq8cePv8otUKO7VEFTBFsIOGE7YNrT26WmyVdBVmIW9N49lVzXzyBsz0ikC6 L5p7rWIbkRD3hXldCdHwubPYvCov3hCCt+oubAadldypbaDG8e5lloWhHb5y7Kgu GvXDlTY0KNWlQ4Fx0Q62bcRRRbqPso2Zq+Q6LJI2FH+MMjwMHyMi7YOvbx58fL2i OhLrWG/xhxoUT2ZqQ4b1sOMjm7HAhfAordBxs4fVcSA5AgglUL5IvrM5n0Dt0qll W1pvENfthOwa7ayNFGIqkimaEORUnNBQ7f+kJHbqZ5/ir4qhuqyKDN+nJ78Nrc9e pB+YB2pfg3D3A8J/Kd04FcpRglzmG6UCj5wQBLoU0817JNQDvf1m6QaEjYTr/y80 Mk6Y6Py0Vxzn2/PZvfh18lY9PfdOI/U0X8XGra1FZuaiPCA0HWHKF9O9zTrSXxM9 5yFc+dFVdl2eYQkxYz6TrkcNAp8dbnmrVtB9qE51WkvM2GlitnTYAB0N+zHdLGG8 oB+W8kBPPJHhBe8Fsst2K/tdtUlW3eZo3VsPOYUsPQ2diTZIFNNs3AK0OEdByjzL 7X9Vni43PPsODZHfyyc06HpcIyfqJR7OPXQpULBq3KKL/ZjcLxg= =GnRF -----END PGP SIGNATURE----- --aba3tildclchg73u--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20211009212056.khm7yupqjbdb6agd>