Date: Mon, 11 Jul 2022 14:37:15 -0400 From: Ryan Moeller <freqlabs@FreeBSD.org> To: freebsd-current@freebsd.org Subject: Re: BLAKE3 unstability? Message-ID: <be7f6fb2-1215-c6d1-73da-fc15571b66be@FreeBSD.org> In-Reply-To: <fab2145d-0a0c-aa62-9866-717d3f8c51d5@FreeBSD.org> References: <20220709162640.7my2bq6rax5npdhf@vax.khramtsov.org> <20220709175605.ofkoft2mglrkaqpf@vax.khramtsov.org> <fab2145d-0a0c-aa62-9866-717d3f8c51d5@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------f316Ma4kSIBCsfrFj4xvK95l
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
On 7/11/22 11:43 AM, Ryan Moeller wrote:
>
> On 7/9/22 1:56 PM, Evgeniy Khramtsov wrote:
>> I can reproduce via:
>>
>> $ truncate -s 10G /tmp/test
>> $ mdconfig -f /tmp/test -S 4096
>> $ zpool create test /dev/md1
>> $ zfs create -o checksum=blake3 test/b
>> $ dd if=/dev/random of=/test/b/noise bs=1M count=4096
>> $ sync
>> $ zpool scrub test
>> $ zpool status
>
> I cannot reproduce this on openzfs/zfs@cb01da68057 (the commit that
> was most recently merged) built out of tree on either stable/13
> 70fd40edb86 or main 9aa02d5120a.
>
> I'll update a system and see if I can reproduce it with the in-tree ZFS.
>
> - Ryan
>
It did not reproduce for me with in-tree ZFS on main@3c9ad9398fcd either.
Could you share sysctl kstat.zfs.misc.chksum_bench, maybe we are using
different implementations?
I do see that blake3 went in with only a Linux module parameter for the
implementation selection, so I'll have to fix that. For now we can at
least see which was fastest, which should be the one selected. You just
won't be able to manually change it to see if that helps.
- Ryan
--------------f316Ma4kSIBCsfrFj4xvK95l
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
On 7/11/22 11:43 AM, Ryan Moeller wrote:
<br>
<blockquote type="cite" style="color: #007cff;">
<br>
On 7/9/22 1:56 PM, Evgeniy Khramtsov wrote:
<br>
<blockquote type="cite" style="color: #007cff;">I can reproduce
via:
<br>
<br>
$ truncate -s 10G /tmp/test
<br>
$ mdconfig -f /tmp/test -S 4096
<br>
$ zpool create test /dev/md1
<br>
$ zfs create -o checksum=blake3 test/b
<br>
$ dd if=/dev/random of=/test/b/noise bs=1M count=4096
<br>
$ sync
<br>
$ zpool scrub test
<br>
$ zpool status
<br>
</blockquote>
<br>
I cannot reproduce this on openzfs/zfs@cb01da68057 (the commit
that was most recently merged) built out of tree on either
stable/13 70fd40edb86 or main 9aa02d5120a.
<br>
<br>
I'll update a system and see if I can reproduce it with the
in-tree ZFS.
<br>
<br>
- Ryan
<br>
<br>
</blockquote>
It did not reproduce for me with in-tree ZFS on main@3c9ad9398fcd
either.
<br>
<br>
Could you share sysctl kstat.zfs.misc.chksum_bench, maybe we are
using different implementations?
<br>
I do see that blake3 went in with only a Linux module parameter for
the implementation selection, so I'll have to fix that. For now we
can at least see which was fastest, which should be the one
selected. You just won't be able to manually change it to see if
that helps.
<br>
<br>
- Ryan
</body>
</html>
--------------f316Ma4kSIBCsfrFj4xvK95l--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?be7f6fb2-1215-c6d1-73da-fc15571b66be>