Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Sep 2016 11:38:38 -0500
From:      Mark Kamichoff <prox@prolixium.com>
To:        "Andrey V. Elsukov" <ae@FreeBSD.org>
Cc:        freebsd-net@FreeBSD.org
Subject:   Re: ICMPv6 HL Exceeded Messages Generated from Wrong Address
Message-ID:  <20160929163838.GA27564@prolixium.com>
In-Reply-To: <fb8a71f4-3b5c-8aa8-d281-ed5de5bdb868@FreeBSD.org>
References:  <20160929031108.GA1530@prolixium.com> <fb8a71f4-3b5c-8aa8-d281-ed5de5bdb868@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 29, 2016 at 09:52:20AM +0300, Andrey V. Elsukov wrote:
> Hi,
> 
> can you test this patch?
> 
> -- 
> WBR, Andrey V. Elsukov

> Index: icmp6.c
> ===================================================================
> --- icmp6.c	(revision 305970)
> +++ icmp6.c	(working copy)
> @@ -2203,7 +2203,7 @@ icmp6_reflect(struct mbuf *m, size_t off)
>  		 * that we do not own.  Select a source address based on the
>  		 * source address of the erroneous packet.
>  		 */
> -		in6_splitscope(&ip6->ip6_dst, &dst6, &scopeid);
> +		in6_splitscope(&ip6->ip6_src, &dst6, &scopeid);
>  		error = in6_selectsrc_addr(RT_DEFAULT_FIB, &dst6,
>  		    scopeid, NULL, &src6, &hlim);
>  

I just tested this.  ICMPv6 HL exceeded packets are now emitted from the
incoming (correct) interface.  Thank you!

- Mark

-- 
Mark Kamichoff
prox@prolixium.com
http://www.prolixium.com/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160929163838.GA27564>