Date: Sat, 21 May 2005 06:49:56 +0900 From: JINMEI Tatuya / =?ISO-2022-JP?B?GyRCP0BMQEMjOkgbKEI=?= <jinmei@isl.rdc.toshiba.co.jp> To: snap-users@kame.net Cc: freebsd-net@freebsd.org Subject: Re: Code nit questions... Message-ID: <y7vy8a9lg8r.wl%jinmei@isl.rdc.toshiba.co.jp> In-Reply-To: <m2k6lxu3s9.wl%gnn@neville-neil.com> References: <m2acmzet7b.wl%gnn@neville-neil.com> <y7vmzqulzj8.wl%jinmei@isl.rdc.toshiba.co.jp> <m2k6lxu3s9.wl%gnn@neville-neil.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>>>>> On Tue, 17 May 2005 11:05:10 -0700, >>>>> gnn@freebsd.org said: >> > *) Insert proper return value checking. >> >> in6_embedscope() should not fail in this context (so we could even >> panic if it does), but you probably want to be very proactive by >> eliminating as many (hidden) assumptions as possible. If so, please >> go ahead with the change, but then I'd rather check the return value >> of in6_recoverscope() as well. The latest KAME snap does not use ip6_embedscope() or in6_recoverscope() in the corresponding part. So, please simply go ahead with whatever change you want to make. BTW: you do not necessarily have to wait for the KAME snap before committing changes to the FreeBSD repository, particularly for trivial fixes like this one. Of course, we always appreciate a prior notice and solicitation of comments. JINMEI, Tatuya Communication Platform Lab. Corporate R&D Center, Toshiba Corp. jinmei@isl.rdc.toshiba.co.jp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?y7vy8a9lg8r.wl%jinmei>