Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Mar 2010 13:29:55 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        freebsd-hackers@freebsd.org
Cc:        Alexander Best <alexbestms@wwu.de>
Subject:   Re: [patch] somebody please fix this outstanding mmap(2) bug
Message-ID:  <201003221329.55369.jhb@freebsd.org>
In-Reply-To: <permail-20100322150743f0889e84000037e5-a_best01@message-id.uni-muenster.de>
References:  <permail-20100322150743f0889e84000037e5-a_best01@message-id.uni-muenster.de>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 22 March 2010 11:07:43 am Alexander Best wrote:
> could somebody please commit this patch? it's been around forever (2003 or
> 2004) and fixes mmap so the offset argument is being ignored when MAP_ANON 
is
> defined (just like the mmap(2) manual says). right now the offset argument 
is
> being taken into account although MAP_ANON is set!!!
> 
> the pr is kern/71258 (including a little c app to demonstrate the bug)
> 
> i've also sent a followup patch to the pr which returns EINVAL if the offset
> is non zero and MAP_ANON is set, but i guess that might break some code.

I think we should go the EINVAL route, and I will commit the patch you did to 
add that.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003221329.55369.jhb>