Date: Mon, 26 Apr 2010 11:10:18 +0300 From: Eitan Adler <eitanadlerlist@gmail.com> To: Garrett Cooper <yanefbsd@gmail.com> Cc: freebsd-hackers@freebsd.org, Ruben de Groot <mail25@bzerk.org>, Doug Barton <dougb@freebsd.org>, "Aryeh M. Friedman" <aryeh.friedman@gmail.com>, =?UTF-8?Q?Trond_Endrest=C3=B8l?= <Trond.Endrestol@fagskolen.gjovik.no> Subject: Re: regenerating /var/db/pkg Message-ID: <m2xa0777e081004260110zd34089a4t22eb15ea709c2119@mail.gmail.com> In-Reply-To: <q2q7d6fde3d1004260059o8b545af7xa13c3a276af2b884@mail.gmail.com> References: <4BCE5ECC.6070202@gmail.com> <o2oa0777e081004220521sae3b1b06o884fd8eadffc6931@mail.gmail.com> <alpine.BSF.2.00.1004221610520.29574@mail.fig.ol.no> <p2oa0777e081004220908w775b40e7r86f0c978b1a05d1e@mail.gmail.com> <4BD07F2D.3030809@FreeBSD.org> <4BD07FCB.4030604@FreeBSD.org> <u2sa0777e081004221005ja2bca37ame13007df67898fcd@mail.gmail.com> <j2p7d6fde3d1004251944x8776db97z1482f6cb10e1ea64@mail.gmail.com> <4BD5009C.20300@FreeBSD.org> <q2q7d6fde3d1004260059o8b545af7xa13c3a276af2b884@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> It would be nice if some of the more usable functions got moved out of > rc.subr though :(... It would cure 20 lines of duplicate code here and > elsewhere outside of rc land... Where should they go? I'll gladly work on a patch to make them available to periodic scripts. > > Yes, and you're assuming that users won't do: > > PKG_DBDIR := /my /super /special/ directory with spaces > > Granted, a lot of things probably won't work that way, but just > compounding to the issue of not quoting variables seems like a silly > mistake to make :/. IMHO a user that uses crazy things should know that things will break Almost no program around correctly handles all filenames: http://www.dwheeler.com/essays/filenames-in-shell.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?m2xa0777e081004260110zd34089a4t22eb15ea709c2119>