Date: Tue, 27 Feb 2001 11:28:20 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Seigo Tanimura <tanimura@r.dl.itc.u-tokyo.ac.jp> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, tanimura@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/sound/isa emu8000.c gusmidi.c mpu.c Message-ID: <XFMail.010227112820.jhb@FreeBSD.org> In-Reply-To: <vmitlwfsdx.wl@rina.r.dl.itc.u-tokyo.ac.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27-Feb-01 Seigo Tanimura wrote: > On Mon, 26 Feb 2001 10:50:52 -0800 (PST), > John Baldwin <jhb@FreeBSD.org> said: > >>> - Mutexify midi(4). The driver runs under the giant lock by default. >>> If you ever want to run midi(4) out of the giant lock, uncomment >>> MIDI_OUTOFGIANT in midi.h. Confirmed to work for csamidi with WITNESS >>> and INVARIANTS. > > John> Err, I hope that you do all mutex operations regardless, and only use > this > > I will do that in my next commit. Ok. > John> option to control setting the INTR_MPSAFE flag for any interrupt > handlers that > John> midi uses. > > Since some interrupt handlers are shared with pcm(4), we have to wait > for pcm(4) to be MP-safe. That is ok. > A couple of questions to ask: > > A. As we might hold a mutex of VM and block, malloc(9) should be > called with holding no mutexes except for Giant. Is that right? Don't do anything with Giant right now. The only thing you should be doing at all in relation to Giant is possibly setting the INTR_MPSAFE flag to mark an interrupt handler as MP safe and thus not needing Giant. > B. Is PI_AV for a multimedia device? If so, I would like to add > INTR_TYPE_AV to enum intr_type and ithread_priority() so that pcm and > midi devices can interrupt at PI_AV. Jake is the one to ask about the new priorities. If PI_AV is for multimedia stuff, then these flags sound ok, but you probably want to run it by the new-bus@FreeBSD.org list first. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010227112820.jhb>