Date: Thu, 30 Sep 1999 00:47:28 -0700 From: Jeremy Lea <reg@shale.csir.co.za> To: Satoshi - Ports Wraith - Asami <asami@freebsd.org> Cc: Bill Fenner <fenner@research.att.com>, ports@freebsd.org Subject: Re: Bad interaction between libtool version check and patches Message-ID: <19990930004728.F35653@shale.csir.co.za> In-Reply-To: <vqczoy427h7.fsf@silvia.hip.berkeley.edu> References: <199909272040.NAA69605@mango.attlabs.att.com> <vqczoy427h7.fsf@silvia.hip.berkeley.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
On Thu, Sep 30, 1999 at 12:17:56AM -0700, Satoshi Asami wrote:
> Actually, I was wondering if we can't just move this whole thing
> before all the pre-* invocations. Jeremy, is there any reason this
> has to be done after the actual patching? The patches can be made to
> apply to the pre-libtool-patch'd files, right?
Actually I was thinking of moving it to before pre-configure, because
one real irritation is that if you run 'make patch' and then try to edit
configure and regenerate the patch, you get a copy which has the
patch-libtool changes. I think there's one example of this already in
the tree...
You need to be able to patch before for the case where the lines being
replaced are not identical to the lines created by libtool.m4, ie for
ports where the author has rolled their own libtool support.
graphics/jpeg, devel/mm, devel/shtool and devel/pth{-devel} are examples
of this (IIRC). Otherwise we need to be able to override the search
string, or have custom patch-libtool targets in these ports. The simple
patch is just easier.
For a simple solution to Bill's problem see my reply to him.
Regards,
-Jeremy
--
| "Come home my prodigal son, come home and lets be one,
--+-- don't want to see you cry, don't make me tell you why,
| you've lived in a house with me, my blood has set you free,
| in the world you'll surely die, nothing else will satisfy." -MIC
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990930004728.F35653>