Date: Mon, 8 Apr 2002 14:01:23 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Dag-Erling Smorgrav <des@ofug.org> Cc: current@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_unix pam_unix.c Message-ID: <20020408110123.GB68318@sunbay.com> In-Reply-To: <xzp1ydqqyx6.fsf@flood.ping.uio.no> References: <200204072043.g37KhRi76699@freefall.freebsd.org> <20020408101138.GA68318@sunbay.com> <xzp1ydqqyx6.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
--neYutvxvOLaeuPCA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 08, 2002 at 12:15:17PM +0200, Dag-Erling Smorgrav wrote: > Ruslan Ermilov <ru@FreeBSD.org> writes: > > On Sun, Apr 07, 2002 at 01:43:27PM -0700, Dag-Erling Smorgrav wrote: > > > Log: > > > Fix bug in previous commit that passed the wrong default value to > > > login_getcapstr(3). Also fix a longer-standing bug (login_close(3) > > > frees the string returned by login_getcapstr(3)) by reorganizing the > > > code a little, and use login_getpwclass(3) instead of login_getclas= s(3) > > > if we already have a struct pwd. > > This change also broke the "Password:" prompt. The bug is hidden by > > the -Wno-uninitialized setting in bsd.sys.mk. Here's the patch: >=20 > The commit you quote *fixed* the bug you're referring to. >=20 You're right. I forgot to relink pam_ssh.so library, and the diff was against the wrong revision. I will still commit the "const poisoning" patch to libutil, as the impact turned out to be really low. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --neYutvxvOLaeuPCA Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE8sXiDUkv4P6juNwoRAnxZAJ986Q+shvQe4qTmcTNAqr1J1w/KrQCeMXl5 iAnMyEayeWM44AgnXHvJXOQ= =Z8rh -----END PGP SIGNATURE----- --neYutvxvOLaeuPCA-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020408110123.GB68318>