Date: Fri, 11 Jan 2002 14:55:38 -0800 From: Alfred Perlstein <bright@mu.org> To: Dag-Erling Smorgrav <des@ofug.org> Cc: Marcel Moolenaar <marcel@xcllnt.net>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_ioctl.c Message-ID: <20020111145538.O7984@elvis.mu.org> In-Reply-To: <xzp8zb4h5ox.fsf@flood.ping.uio.no>; from des@ofug.org on Fri, Jan 11, 2002 at 11:40:46PM %2B0100 References: <200201100536.g0A5aao01807@freefall.freebsd.org> <xzpy9j5hecf.fsf@flood.ping.uio.no> <20020110191209.A318@dhcp01.pn.xcllnt.net> <xzpu1tth859.fsf@flood.ping.uio.no> <20020110203918.A440@dhcp01.pn.xcllnt.net> <xzppu4hgkwg.fsf@flood.ping.uio.no> <20020111112851.A2103@kayak.xcllnt.net> <xzpd70ghc78.fsf@flood.ping.uio.no> <20020111122534.K7984@elvis.mu.org> <xzp8zb4h5ox.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
* Dag-Erling Smorgrav <des@ofug.org> [020111 14:46] wrote: > Alfred Perlstein <bright@mu.org> writes: > > * Dag-Erling Smorgrav <des@ofug.org> [020111 12:20] wrote: > > > Since when does "talking it over first" mean "commit a patch without > > > discussing it with the person who wrote the code it changes"? > > > Especially when similar patches have been suggested, discussed, and > > > rejected before (see for instance the audit trail for PR 26546). > > You don't give a reason for your: > > "Partial fix committed, more work remains to be done." > > See the log entry for revision 1.68 of linux_ioctl.c, and succeeding > revisions. The revision in which the fix was incorperated should have been logged in the PR. > > It would make both the PR originator as well as fellow developers > > understand why and how you are doing things. > > Both ambrisko (who submitted the PR) and marcel were involved in the > development of the patches I *did* commit. Then you're most likely in the right. Your attitude however works hard against that. Perhaps if you would approach these situations with a bit more flexibility/gentelness things would work out a bit smoother. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductable donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020111145538.O7984>