Date: Thu, 27 Jun 2002 04:51:40 +0400 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Dag-Erling Smorgrav <des@ofug.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh-portable session.c Message-ID: <20020627005139.GA3331@nagual.pp.ru> In-Reply-To: <xzpfzz91xbk.fsf@flood.ping.uio.no> References: <200206261417.g5QEHTjR074759@freefall.freebsd.org> <20020626152357.GA30110@nagual.pp.ru> <xzpznxh1z2q.fsf@flood.ping.uio.no> <20020626221708.GA2178@nagual.pp.ru> <xzpfzz91xbk.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 27, 2002 at 00:37:03 +0200, Dag-Erling Smorgrav wrote:
> "Andrey A. Chernov" <ache@nagual.pp.ru> writes:
> > BTW, it seems we have a bug in our login(1), login.c - new code does
> > setenv(PATH...) _after_ setusercontext(), it means path= command in
> > standard /etc/login.conf will not works.
>
> man 3 setenv
Of course. I look too quick on code there and agree that PATH handling in
login.c is right.
But, what happens with TERM in login.c?
(void)setenv("TERM", stypeof(tty), 0);
^^^ not owervrite
I.e. it is not overwritted after setusercontext(). We definitely need an
agreement here. Ether both login & sshd must overwrite TERM after
setusercontext() or both do not. It seems that there is login.c bug in
the light of login.conf(5) "term" description.
--
Andrey A. Chernov
http://ache.pp.ru/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020627005139.GA3331>