Date: Tue, 4 Dec 2001 16:15:52 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Dag-Erling Smorgrav <des@ofug.org> Cc: Bill Fenner <fenner@research.att.com>, Garrett Wollman <wollman@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_mroute.c ip_output.c Message-ID: <20011204161552.E67698@sunbay.com> In-Reply-To: <xzpg06r8ar1.fsf@flood.ping.uio.no> References: <200112011348.fB1DmGf07402@freefall.freebsd.org> <200112012051.fB1KpAp47152@khavrinen.lcs.mit.edu> <20011203114032.C60143@sunbay.com> <200112040151.RAA00166@windsor.research.att.com> <20011204103455.B26925@sunbay.com> <xzpg06r8ar1.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 04, 2001 at 12:50:42PM +0100, Dag-Erling Smorgrav wrote: > Ruslan Ermilov <ru@FreeBSD.org> writes: > > This change did not eliminate "one test" actually, as the test was > > still done, and in the case of a match ip_output() just panic()ed. > > The test should be changed into a KASSERT, then. > DES, Please look at the actual code before replying. :-) The new code doesn't have this test at all, and simply uses the on-stack "struct route", if one wasn't supplied by a caller. I was just commenting on the change Garrett made in rev. 1.35. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011204161552.E67698>