Date: Sat, 5 Dec 2015 09:02:55 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Jan Beich <jbeich@vfemail.net> Cc: Euan Thoms <euan@potensol.com>, FreeBSD Ports Mailing List <freebsd-ports@freebsd.org> Subject: Re: MAKEFLAGS caused temporary insanity Message-ID: <566318BF.2030104@FreeBSD.org> In-Reply-To: <zixp-p8gz-wny@vfemail.net> References: <b2f0-56553280-3-6b8b4580@170958255> <5662376C.8090809@FreeBSD.org> <zixp-p8gz-wny@vfemail.net>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 12/5/15 1:09 AM, Jan Beich wrote:
> Bryan Drewery <bdrewery@FreeBSD.org> writes:
>
>> On 11/24/2015 8:00 PM, Euan Thoms wrote:
>>
>>>
>>> On Tuesday, November 24, 2015 11:15 SGT, Jan Beich
>>> <jbeich@vfemail.net> wrote:
>>>
>>>> "Euan Thoms" <euan@potensol.com> writes:
>>>>
>>>>> do-build: cd ${WRKSRC} && unset MAKEFLAGS &&
>>>>> ${OPENSIPS_MAKE_ENV} ${GMAKE} ${_MAKE_JOBS} ${ALL_TARGET}
>>>>
>>>> Have you tried defining NOPRECIOUSMAKEVARS in the port's
>>>> Makefile?
>>>>
>>>
>>> That did the trick, thanks. I can now remove the "unset
>>> MAKEFLAGS" in do-build.
>>>
>>>
>>
>> As far as I can tell NOPRECIOUSMAKEVARS does not impact the
>> variable literally named 'MAKEFLAGS'. It should only be impacting
>> these:
>>
>> # make -V _EXPORTED_VARS ARCH OPSYS _OSRELEASE OSREL OSVERSION
>> _PKG_CHECKED HAVE_COMPAT_IA32_KERN _SMP_CPUS
>> CONFIGURE_MAX_CMD_LEN
>
> Did you read my reply untrimmed? net/opensips uses ARCH in vendor
> Makefile
This is what I was looking for.
> and the framework clobbers its value. Some ports like
> multimedia/ffmpeg rename the variable, others give up and define
> NOPRECIOUSMAKEVARS.
>
>> Which port was this? Which release are you running (real question
>> is whether it was fmake or bmake)?
>
> Affects both. I did propose 2 ways to fix.
>
The real fix would be to not export these to the port builds. We
experimented with using 'env -i' in the build a few years back and had
a lot of fallout.
- --
Regards,
Bryan Drewery
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQEcBAEBCgAGBQJWYxi/AAoJEDXXcbtuRpfPghcIAMOzkIFfm4+s7MXi2/B6UrqB
r9wvv9zsFZ5ytASFhuecm+47ZWkJq3sKmlw3vXHqRJRR8V9r7vhGBSINfwrOTiUE
ZMIk29/tJ1Bkdl9SDt34xU38WZD1gz+35qNZQbrpr6g1+2qGr2iX/UEOBGp6Bzrl
O6EAK18a34cbOGSwMCVxZoLhsHD2fjbLnGRROILKztE+h3s4Q2P+phQCzSGnL0vD
DqY4dLi5mKJgOj68xNJQeQKZm10+Dt+F8zdSspA6coDdnU4uRe5YxLxNLeJXpHav
CsxYLZCrYvvYaMhXHL69Lq70UdWR3L2k6bZkC/QjZlJeFNMZ6WjGSgCXrG9VWdQ=
=CJVz
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?566318BF.2030104>