Date: Thu, 13 Oct 2005 01:13:13 +0400 From: "Yuriy N. Shkandybin" <jura@networks.ru> To: "John Baldwin" <jhb@freebsd.org> Cc: freebsd-net@freebsd.org Subject: Re: if_nge & if_lge drivers Message-ID: <002c01c5cf72$54901fc0$0701010a@notebook> References: <092e01c5cb15$f7fe5840$6504010a@Jura> <200510121610.47507.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > Note that lge() has a bzero() call after the contigmalloc(), but M_ZERO is > probably better to use: > > sc->lge_ldata = contigmalloc(sizeof(struct lge_list_data), M_DEVBUF, > M_NOWAIT, 0, 0xffffffff, PAGE_SIZE, 0); > > ... > bzero(sc->lge_ldata, sizeof(struct lge_list_data)); > Yes, i;ve missed that. But there is no such bzero in nge. > I'll put that in my lge(4) patches and incorporate your nge(4) patches. > One > issue with your nge(4) patch is that you moved the bus_setup_intr() up > when > it really should happen after ether_ifattach(). > Probably. I've looked into if_lge.c for that as example. There goes bus_setup_intr() first and later ether_ifattach(). > > Also, is there a reason you added a call to nge_reset() after nge_stop() > in > nge_init()? > Only reason - same done in if_lge.c Jura
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?002c01c5cf72$54901fc0$0701010a>