Date: Sun, 10 Nov 2002 00:55:49 +0200 From: "Giorgos Keramidas" <keramida@FreeBSD.org> To: "Thomas Moestl" <tmm@FreeBSD.org> Cc: <doc@FreeBSD.org> Subject: Re: Please review: small patches for building documentation on FreeBSD/sparc64 Message-ID: <010d01c28843$26923e60$42d7cdd4@LocalHost> References: <20021106150326.GA334@crow.dom2ip.de> <20021107080342.A48030@misty.eyesbeyond.com> <20021109221334.GB316@crow.dom2ip.de>
next in thread | previous in thread | raw e-mail | index | archive | help
"Thomas Moestl" <tmm@FreeBSD.ORG> wrote:
To: "Greg Lewis" <glewis@eyesbeyond.com>
: On Thu, 2002/11/07 at 08:03:43 +1030, Greg Lewis wrote:
: > On Wed, Nov 06, 2002 at 04:03:26PM +0100, Thomas Moestl wrote:
: > > -.if ${MACHINE_ARCH} == "alpha"
: > > +.if ${MACHINE_ARCH} == "alpha" || ${MACHINE_ARCH} == "sparc64"
: >
: > Might it be better to convert this and similar logic to check for "i386"
: > and activate jade in that case (effectively making openjade the default)?
: > Particularly if people think ia64 is likely to also use openjade.
:
: Sounds reasonable. I've attached the new patches, which I would like
: to commit soonish unless there are objections.
The following (the doc part of the diff) looks fine. I haven't tested
it with a full doc build, but if it survives a build of doc/ with:
% make FORMATS="html txt"
then commit away (it's simple, so I don't see anything that could
probably cause it to fail, but check before you commit it anyway).
%%%
Index: share/mk/doc.docbook.mk
===================================================================
RCS file: /d/ncvs/doc/share/mk/doc.docbook.mk,v
retrieving revision 1.70
diff -u -r1.70 doc.docbook.mk
--- share/mk/doc.docbook.mk 28 Oct 2002 19:44:08 -0000 1.70
+++ share/mk/doc.docbook.mk 4 Nov 2002 11:30:54 -0000
@@ -105,7 +105,7 @@
# Which stylesheet type to use. 'dsssl' or 'xsl'
STYLESHEET_TYPE?= dsssl
-.if ${MACHINE_ARCH} == "alpha"
+.if ${MACHINE_ARCH} != "i386"
OPENJADE= yes
.endif
Index: share/mk/doc.html.mk
===================================================================
RCS file: /d/ncvs/doc/share/mk/doc.html.mk,v
retrieving revision 1.12
diff -u -r1.12 doc.html.mk
--- share/mk/doc.html.mk 7 Jul 2002 05:05:46 -0000 1.12
+++ share/mk/doc.html.mk 4 Nov 2002 11:30:54 -0000
@@ -51,7 +51,7 @@
IMAGES_LIB?=
-.if ${MACHINE_ARCH} == "alpha"
+.if ${MACHINE_ARCH} != "i386"
OPENJADE= yes
.endif
%%%
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-doc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?010d01c28843$26923e60$42d7cdd4>