Date: Wed, 25 Jul 2001 10:59:59 +0800 From: "Da better Half" <tayerv@team.ph.inter.net> To: "Valeriy E. Ushakov" <uwe@ptc.spbu.ru>, <freebsd-stable@FreeBSD.ORG> Subject: Re: wc, tagging &c (not a troll ;) Message-ID: <018501c114b5$e4ef2b00$4b443dca@jett> References: <20010725070644.A14953@snark.ptc.spbu.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
does this concern freebsd-stable? ----- Original Message ----- From: "Valeriy E. Ushakov" <uwe@ptc.spbu.ru> To: <freebsd-stable@FreeBSD.ORG> Sent: Wednesday, July 25, 2001 11:06 AM Subject: wc, tagging &c (not a troll ;) > In my box I have a Quantum drive and an IBM DTLA-307015 drive. The > latter supports tagged queuing, as ata(4) tells and from the > discussion(s) on this list my understanding is that tags are safe, > unlike write caching (since we sometimes have random power glitches, I > really don't want to turn wc on). > > However code in ata-disk in ad_attach does > > if (ata_wc || ata_tags) > turn on wc > > if (ata_tags && ad_tagsupported(adp)) > turn on tagging > > This makes me nervous as at the first glance it looks like it will > enable wc on my quantum drive even though it doesn't do tagging. > Shouldn't it be: > > do_tagging = ata_tags && ad_tagsupported(adp); > > if (ata_wc || do_tagging) > turn on wc > > if (ata_tags && do_tagging) > turn on tagging > > > Thanks. > > SY, Uwe > -- > uwe@ptc.spbu.ru | Zu Grunde kommen > http://www.ptc.spbu.ru/~uwe/ | Ist zu Grunde gehen > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-stable" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?018501c114b5$e4ef2b00$4b443dca>