Date: Tue, 4 Mar 2003 20:26:03 -0500 From: "Mike Edenfield" <kutulu@kutulu.org> To: <freebsd-hackers@freebsd.org> Subject: D_KQFILTER & ltmdm: Patch for review? Message-ID: <01be01c2e2b6$30742b00$29330f0a@lcapps.educate.com>
next in thread | raw e-mail | index | archive | help
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
Sent: Tuesday, March 04, 2003 5:39 PM
> But your patch is wrong. Please format the initialization like
> you see in all the other device drivers:
I now see what you meant about the formatting. It was the whole reason to
reorder the fields, sorry I missed that. I also removed the redundant
initializations.
Do you (well, does anyone) have a moment to eyeball this patch before I send
it off to the maintainer?
Thanks again,
--Mike
--- sys/dev/ltmdm/ltmdmsio.c.orig Tue Mar 4 19:49:57 2003
+++ sys/dev/ltmdm/ltmdmsio.c Tue Mar 4 20:17:16 2003
@@ -360,6 +360,18 @@
#endif
static struct cdevsw sio_cdevsw = {
+#if __FreeBSD_version >= 500104 /* >= 20030303 */
+ .d_maj = MAJOR_AUTO,
+ .d_flags = D_TTY,
+ .d_name = driver_name,
+ .d_open = sioopen,
+ .d_close = sioclose,
+ .d_read = sioread,
+ .d_write = siowrite,
+ .d_ioctl = sioioctl,
+ .d_poll = ttypoll,
+ .d_kqfilter = ttykqfilter
+#else
/* open */ sioopen,
/* close */ sioclose,
/* read */ sioread,
@@ -389,6 +401,7 @@
/* kqfilter */ ttykqfilter,
#endif
#endif
+#endif /* __FreeBSD_version >= 500104 */
};
static u_int com_events; /* input chars + weighted output completions */
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01be01c2e2b6$30742b00$29330f0a>