Date: Tue, 25 Mar 2014 08:31:52 -0700 From: <dteske@FreeBSD.org> To: "'Bryan Drewery'" <bdrewery@FreeBSD.org> Cc: dteske@FreeBSD.org, sysinstall@FreeBSD.org Subject: RE: bsdinstall ZFS /root in wrong dataset Message-ID: <01cc01cf483f$5a90eae0$0fb2c0a0$@FreeBSD.org> In-Reply-To: <532DA62A.7020106@FreeBSD.org> References: <532D84AF.5080506@FreeBSD.org> <010101cf45de$c9707380$5c515a80$@FreeBSD.org> <532DA62A.7020106@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> -----Original Message----- > From: Bryan Drewery [mailto:bdrewery@FreeBSD.org] > Sent: Saturday, March 22, 2014 8:03 AM > To: dteske@FreeBSD.org > Cc: sysinstall@FreeBSD.org > Subject: Re: bsdinstall ZFS /root in wrong dataset >=20 > On 3/22/2014 9:55 AM, dteske@FreeBSD.org wrote: > >> -----Original Message----- > >> From: Bryan Drewery [mailto:bdrewery@FreeBSD.org] > >> Sent: Saturday, March 22, 2014 5:40 AM > >> To: sysinstall@FreeBSD.org > >> Subject: bsdinstall ZFS /root in wrong dataset > >> > >> (I am not subscribed so please CC me) > >> > >> The ZFS layout uses the zroot/ROOT/<BE> to support boot environments. > >> The problem with it is that /root is part of the BE. Home directories > >> are properly outside of the BE. > >> > >> /root should really be outside to persist history and other changes > >> to > > root's > >> homedir through BE changes/upgrades. > >> > >> This is quite noticeable if you create a new BE (beadm create; beadm > >> mount) and then installworld/kernel into it, then activate and reboot. > >> All of your history and /root changes are missing for the period > >> between creating the BE and rebooting. > >> > >> Something like this is needed: > >> > >>> --- usr.sbin/bsdinstall/scripts/zfsboot (revision 263620) > >>> +++ usr.sbin/bsdinstall/scripts/zfsboot (working copy) > >>> @@ -128,6 +128,8 @@ > >>> > >>> # Home directories separated so they are common to all BEs > >>> /usr/home # NB: /home is a symlink to /usr/home > >>> + /root mountpoint=3D/root > >>> > >>> # Ports tree > >>> /usr/ports compression=3Dlz4,setuid=3Doff > >> > >> > >> Though, I am unsure on whether we should make a zroot/root dataset > >> and mount it in or mkdir /usr/home/root and symlink /root to it. The > >> symlink does cause mergemaster confusion though. I have no opinion on > >> where we create the root dataset, as long as it is outside of ROOT. > >> > > > > Hi bdrewery, > > > > Thanks for kicking off this thread (esp. on list). > > > > Placing /root in /usr/home/root would break in a few scenarios as you > > correctly identified. Let's give your patch a go and wait for some > > feedback before MFC'ing. I don't expect any fallout from your patch; > > looks great and indeed should solve the problem (if I understand correctly). > > > > Do you want to commit or should I? > > >=20 > Sounds good. I'll commit in about an hour. >=20 Got a test result from the commit on -current... > -----Original Message----- > From: Bruno Lauz=E9 [mailto:brunolauze@msn.com] > Sent: Tuesday, March 25, 2014 7:29 AM > To: freebsd-current@freebsd.org > Subject: install error with r263638 >=20 > I am experiencing issue related to r263638.During a ZFS Install, it does create > a new volume for /root but bsdinstall cannot copy "root/.cshrc" during > base.txz extraction.Would we want to [add] ",canmount=3Doff" or change the > way root profile gets created for zfs install? > What could be the cause? Got so much other stuff to think about right now... But I think the user is saying that we broke it ;D --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01cc01cf483f$5a90eae0$0fb2c0a0$>