Date: Mon, 4 Dec 2023 13:00:17 -0500 From: Karl Denninger <karl@denninger.net> To: stable@freebsd.org Subject: Re: FreeBSD Errata Notice FreeBSD-EN-23:16.openzfs Message-ID: <02ab3650-3e42-4e92-a14f-559d9d3b0b13@denninger.net> In-Reply-To: <CAGMYy3vF6h=4ZM5tBFUzNk3TX83cP5j_MiRsF6J3bm6%2BWPfS8w@mail.gmail.com> References: <20231201031737.DF0231B942@freefall.freebsd.org> <ZWsI4SbNU2xPjaPF@marvin.hueftgold.tld> <ZW2P8xz046Eqo_0u@fc.opsec.eu> <445y1eaxiz.fsf@be-well.ilk.org> <20231204230246.f11fce2914500a99e094de0b@dec.sakura.ne.jp> <CAGMYy3vF6h=4ZM5tBFUzNk3TX83cP5j_MiRsF6J3bm6%2BWPfS8w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a cryptographically signed message in MIME format.
--------------ms020407070906030709080402
Content-Type: multipart/alternative;
boundary="------------OPEkGwm264EgXFclFmeylaNj"
--------------OPEkGwm264EgXFclFmeylaNj
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
On 12/4/2023 12:51, Xin LI wrote:
>
>
> On Mon, Dec 4, 2023 at 8:32 AM Tomoaki AOKI
> <junchoon@dec.sakura.ne.jp> wrote:
>
> On Mon, 04 Dec 2023 08:48:52 -0500
> Lowell Gilbert <freebsd-stable-local@be-well.ilk.org> wrote:
>
> > Kurt Jaeger <pi@freebsd.org> writes:
> >
> > > I had thought that the ZFS fix is a kernel fix so that the kernel
> > > would also report -p1, but it does not. It might be because
> > > zfs is a kernel module, so the kernel itself was not really
> patched,
> > > but I might be wrong here.
> >
> > As far as I can see, that seems exactly right.
>
> As this kind of confusion caused by mismatch of patchlevel between
> kernel and userland arises from time to time, now would be the time to
> switch to keep patchlevel in sync between kernel and userland.
>
> This would force both kernel and userland to be built using the same
> patchlevel, even if one of which is actually unchanged.
> But maybe helpful to avoid confusion like this.
>
> What was worse this time was that a non-in-kernel-but-in-tree module,
> zfs.ko, is updated but kernel itself is not updated.
>
>
> Part of this is because freebsd-update generally wants to exclude
> cosmetic changes (like build timestamps, etc., which does not have an
> effect on runtime behavior) in binary patches, so in order to "fix"
> this we would need to change the update builder, at the expense of
> always delivering a kernel change regardless if there are any real
> changes to the binary. At the time when I owned the builder code, the
> consensus was that we are moving to a packaged base really soon (tm)
> and the builder is in "maintenance mode" so we didn't invest a lot in
> this front.
>
> Cheers,
I would argue that if /kernel modules /are implicated in a patch then
either (1) the kernel /version /has to come from a module (and thus be
bumped if any of said modules are updated) or (2) the kernel /itself
/has to be updated so its version can be patched.
#1 is obviously a /lot/ less intrusive and perhaps the correct answer:
/The "kernel revision" is incremented when *_either_* the kernel itself
or any of its loadable modules are patched/updated, and the revision
*_itself_* is in a loadable module and thus can be updated as a tiny
little file instead of the entire kernel./
--
Karl Denninger
karl@denninger.net
/The Market Ticker/
/[S/MIME encrypted email preferred]/
--------------OPEkGwm264EgXFclFmeylaNj
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">On 12/4/2023 12:51, Xin LI wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAGMYy3vF6h=4ZM5tBFUzNk3TX83cP5j_MiRsF6J3bm6+WPfS8w@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr">
<div class="gmail_default"
style="font-family:monospace,monospace"><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Dec 4, 2023 at
8:32 AM Tomoaki AOKI <<a
href="mailto:junchoon@dec.sakura.ne.jp"
moz-do-not-send="true" class="moz-txt-link-freetext">junchoon@dec.sakura.ne.jp</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On
Mon, 04 Dec 2023 08:48:52 -0500<br>
Lowell Gilbert <<a
href="mailto:freebsd-stable-local@be-well.ilk.org"
target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">freebsd-stable-local@be-well.ilk.org</a>>
wrote:<br>
<br>
> Kurt Jaeger <<a href="mailto:pi@freebsd.org"
target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">pi@freebsd.org</a>>
writes:<br>
> <br>
> > I had thought that the ZFS fix is a kernel fix so
that the kernel<br>
> > would also report -p1, but it does not. It might
be because<br>
> > zfs is a kernel module, so the kernel itself was
not really patched,<br>
> > but I might be wrong here.<br>
> <br>
> As far as I can see, that seems exactly right.<br>
<br>
As this kind of confusion caused by mismatch of patchlevel
between<br>
kernel and userland arises from time to time, now would be
the time to<br>
switch to keep patchlevel in sync between kernel and
userland.<br>
<br>
This would force both kernel and userland to be built using
the same<br>
patchlevel, even if one of which is actually unchanged.<br>
But maybe helpful to avoid confusion like this.<br>
<br>
What was worse this time was that a
non-in-kernel-but-in-tree module,<br>
zfs.ko, is updated but kernel itself is not updated.</blockquote>
<div><br>
</div>
<div class="gmail_default"
style="font-family:monospace,monospace">Part of this is
because freebsd-update generally wants to exclude cosmetic
changes (like build timestamps, etc., which does not have an
effect on runtime behavior) in binary patches, so in order
to "fix" this we would need to change the update builder, at
the expense of always delivering a kernel change regardless
if there are any real changes to the binary. At the time
when I owned the builder code, the consensus was that we are
moving to a packaged base really soon (tm) and the builder
is in "maintenance mode" so we didn't invest a lot in this
front.</div>
<div class="gmail_default"
style="font-family:monospace,monospace"><br>
</div>
<div class="gmail_default"
style="font-family:monospace,monospace">Cheers,</div>
</div>
</div>
</blockquote>
<p>I would argue that if <i>kernel modules </i>are implicated in a
patch then either (1) the kernel <i>version </i>has to come from
a module (and thus be bumped if any of said modules are updated)
or (2) the kernel <i>itself </i>has to be updated so its version
can be patched.</p>
<p>#1 is obviously a <i>lot</i> less intrusive and perhaps the
correct answer: <i>The "kernel revision" is incremented when <b><u>either</u></b>
the kernel itself or any of its loadable modules are
patched/updated, and the revision <b><u>itself</u></b> is in a
loadable module and thus can be updated as a tiny little file
instead of the entire kernel.</i></p>
<div class="moz-signature">-- <br>
Karl Denninger<br>
<a href="mailto:karl@denninger.net" class="moz-txt-link-freetext">karl@denninger.net</a><br>
<i>The Market Ticker</i><br>
<font size="-2"><i>[S/MIME encrypted email preferred]</i></font></div>
</body>
</html>
--------------OPEkGwm264EgXFclFmeylaNj--
--------------ms020407070906030709080402
Content-Type: application/pkcs7-signature; name="smime.p7s"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="smime.p7s"
Content-Description: S/MIME Cryptographic Signature
MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgMFADCABgkqhkiG9w0BBwEAAKCC
DbowggagMIIEiKADAgECAhMA5EiKghDOXrvfxYxjITXYDdhIMA0GCSqGSIb3DQEBCwUAMIGL
MQswCQYDVQQGEwJVUzEQMA4GA1UECAwHRmxvcmlkYTESMBAGA1UEBwwJTmljZXZpbGxlMRkw
FwYDVQQKDBBDdWRhIFN5c3RlbXMgTExDMRgwFgYDVQQLDA9DdWRhIFN5c3RlbXMgQ0ExITAf
BgNVBAMMGEN1ZGEgU3lzdGVtcyBMTEMgMjAxNyBDQTAeFw0xNzA4MTcxNjQyMTdaFw0yNzA4
MTUxNjQyMTdaMHsxCzAJBgNVBAYTAlVTMRAwDgYDVQQIDAdGbG9yaWRhMRkwFwYDVQQKDBBD
dWRhIFN5c3RlbXMgTExDMRgwFgYDVQQLDA9DdWRhIFN5c3RlbXMgQ0ExJTAjBgNVBAMMHEN1
ZGEgU3lzdGVtcyBMTEMgMjAxNyBJbnQgQ0EwggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIK
AoICAQC1aJotNUI+W4jP7xQDO8L/b4XiF4Rss9O0B+3vMH7Njk85fZ052QhZpMVlpaaO+sCI
KqG3oNEbuOHzJB/NDJFnqh7ijBwhdWutdsq23Ux6TvxgakyMPpT6TRNEJzcBVQA0kpby1DVD
0EKSK/FrWWBiFmSxg7qUfmIq/mMzgE6epHktyRM3OGq3dbRdOUgfumWrqHXOrdJz06xE9NzY
vc9toqZnd79FUtE/nSZVm1VS3Grq7RKV65onvX3QOW4W1ldEHwggaZxgWGNiR/D4eosAGFxn
uYeWlKEC70c99Mp1giWux+7ur6hc2E+AaTGh+fGeijO5q40OGd+dNMgK8Es0nDRw81lRcl24
SWUEky9y8DArgIFlRd6d3ZYwgc1DMTWkTavx3ZpASp5TWih6yI8ACwboTvlUYeooMsPtNa9E
6UQ1nt7VEi5syjxnDltbEFoLYcXBcqhRhFETJe9CdenItAHAtOya3w5+fmC2j/xJz29og1KH
YqWHlo3Kswi9G77an+zh6nWkMuHs+03DU8DaOEWzZEav3lVD4u76bKRDTbhh0bMAk4eXriGL
h4MUoX3Imfcr6JoyheVrAdHDL/BixbMH1UUspeRuqQMQ5b2T6pabXP0oOB4FqldWiDgJBGRd
zWLgCYG8wPGJGYgHibl5rFiI5Ix3FQncipc6SdUzOQIDAQABo4IBCjCCAQYwHQYDVR0OBBYE
FF3AXsKnjdPND5+bxVECGKtc047PMIHABgNVHSMEgbgwgbWAFBu1oRhUMNEzjODolDka5k4Q
EDBioYGRpIGOMIGLMQswCQYDVQQGEwJVUzEQMA4GA1UECAwHRmxvcmlkYTESMBAGA1UEBwwJ
TmljZXZpbGxlMRkwFwYDVQQKDBBDdWRhIFN5c3RlbXMgTExDMRgwFgYDVQQLDA9DdWRhIFN5
c3RlbXMgQ0ExITAfBgNVBAMMGEN1ZGEgU3lzdGVtcyBMTEMgMjAxNyBDQYIJAKxAy1WBo2kY
MBIGA1UdEwEB/wQIMAYBAf8CAQAwDgYDVR0PAQH/BAQDAgGGMA0GCSqGSIb3DQEBCwUAA4IC
AQCB5686UCBVIT52jO3sz9pKuhxuC2npi8ZvoBwt/IH9piPA15/CGF1XeXUdu2qmhOjHkVLN
gO7XB1G8CuluxofOIUce0aZGyB+vZ1ylHXlMeB0R82f5dz3/T7RQso55Y2Vog2Zb7PYTC5B9
oNy3ylsnNLzanYlcW3AAfzZcbxYuAdnuq0Im3EpGm8DoItUcf1pDezugKm/yKtNtY6sDyENj
tExZ377cYA3IdIwqn1Mh4OAT/Rmh8au2rZAo0+bMYBy9C11Ex0hQ8zWcvPZBDn4v4RtO8g+K
uQZQcJnO09LJNtw94W3d2mj4a7XrsKMnZKvm6W9BJIQ4Nmht4wXAtPQ1xA+QpxPTmsGAU0Cv
HmqVC7XC3qxFhaOrD2dsvOAK6Sn3MEpH/YrfYCX7a7cz5zW3DsJQ6o3pYfnnQz+hnwLlz4MK
17NIA0WOdAF9IbtQqarf44+PEyUbKtz1r0KGeGLs+VGdd2FLA0e7yuzxJDYcaBTVwqaHhU2/
Fna/jGU7BhrKHtJbb/XlLeFJ24yvuiYKpYWQSSyZu1R/gvZjHeGb344jGBsZdCDrdxtQQcVA
6OxsMAPSUPMrlg9LWELEEYnVulQJerWxpUecGH92O06wwmPgykkz//UmmgjVSh7ErNvL0lUY
UMfunYVO/O5hwhW+P4gviCXzBFeTtDZH259O7TCCBxIwggT6oAMCAQICEgLG8yH4PQFdbd9x
Ugmpzl1jXzANBgkqhkiG9w0BAQsFADB7MQswCQYDVQQGEwJVUzEQMA4GA1UECAwHRmxvcmlk
YTEZMBcGA1UECgwQQ3VkYSBTeXN0ZW1zIExMQzEYMBYGA1UECwwPQ3VkYSBTeXN0ZW1zIENB
MSUwIwYDVQQDDBxDdWRhIFN5c3RlbXMgTExDIDIwMTcgSW50IENBMB4XDTIyMDYyOTE2MTYz
NloXDTI3MDYyODE2MTYzNlowOjELMAkGA1UEBhMCVVMxEjAQBgNVBAgMCVRlbm5lc3NlZTEX
MBUGA1UEAwwOS2FybCBEZW5uaW5nZXIwggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIKAoIC
AQC+HVSyxVtJhy3Ohs+PAGRuO//Dha9A16l5FPATr6wude9zjX5f2lrkRyU8vhCXTZW7WbvW
ZKpcZ8r0dtZmiK9uF58Ec6hhvfkxJzbg96WHBw5Fumd5ahZzuCJDtCAWW8R7/KN+zwzQf1+B
3MVLmbaXAFBuKzySKhKMcHbK3/wjUYTgy+3UK6v2SBrowvkUBC+jxNg3Wy12GsTXcUS/8FYI
XgVVPgfZZrbJJb5HWOQpvvhILpPCD3xsYJFNKEPltXKWHT7Qtc2HNqikgNwj8oqOb+PeZGMi
WapsatKm8mxuOOGOEBhAoTVTwUHlMNTg6QUCJtuWFCK38qOCyk9Haj+86lUU8RG6FkRXWgMb
NQm1mWREQhw3axgGLSntjjnznJr5vsvXSYR6c+XKLd5KQZcS6LL8FHYNjqVKHBYM+hDnrTZM
qa20JLAF1YagutDiMRURU23iWS7bA9tMcXcqkclTSDtFtxahRifXRI7Epq2GSKuEXe/1Tfb5
CE8QsbCpGsfSwv2tZ/SpqVG08MdRiXxN5tmZiQWo15IyWoeKOXl/hKxA9KPuDHngXX022b1l
y+5ZOZbxBAZZMod4y4b4FiRUhRI97r9lCxsP/EPHuuTIZ82BYhrhbtab8HuRo2ofne2TfAWY
2BlA7ExM8XShMd9bRPZrNTokPQPUCWCgCdIATQIDAQABo4IBzzCCAcswPAYIKwYBBQUHAQEE
MDAuMCwGCCsGAQUFBzABhiBodHRwOi8vb2NzcC5jdWRhc3lzdGVtcy5uZXQ6ODg4ODAJBgNV
HRMEAjAAMBEGCWCGSAGG+EIBAQQEAwIFoDAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYI
KwYBBQUHAwIGCCsGAQUFBwMEMDMGCWCGSAGG+EIBDQQmFiRPcGVuU1NMIEdlbmVyYXRlZCBD
bGllbnQgQ2VydGlmaWNhdGUwHQYDVR0OBBYEFLElmNWeVgsBPe7O8NiBzjvjYnpRMIHKBgNV
HSMEgcIwgb+AFF3AXsKnjdPND5+bxVECGKtc047PoYGRpIGOMIGLMQswCQYDVQQGEwJVUzEQ
MA4GA1UECAwHRmxvcmlkYTESMBAGA1UEBwwJTmljZXZpbGxlMRkwFwYDVQQKDBBDdWRhIFN5
c3RlbXMgTExDMRgwFgYDVQQLDA9DdWRhIFN5c3RlbXMgQ0ExITAfBgNVBAMMGEN1ZGEgU3lz
dGVtcyBMTEMgMjAxNyBDQYITAORIioIQzl6738WMYyE12A3YSDAdBgNVHREEFjAUgRJrYXJs
QGRlbm5pbmdlci5uZXQwDQYJKoZIhvcNAQELBQADggIBAKquc7cu0xc8FNtAQauZvocDzWQj
7HG9YvMbWnMi+ckhiA3rdW5NwWg0HBhBho1YlnqV+ntCVE2L8ezohHWm+KAdfXgpraL86Vsn
3ywNlZu/3COMpo2ALuHln8YQtH3Y8ebvzKMdlf2b5WB+7mOFIxXIr4AnNOLKCkq5ZhzC6JW6
Jvw3P0csiGa3UrfatYID5NvPgkaQvEgimEjG3psZqwQTL2Wxohvw783PrDt3wS0XeNhvQ61g
3QJFZKuv+bmGH3YBSPo1t6NUGAr+JozX5lDihB8JGkBt/NwdYec49a08uL0BbPaAJ7NjuIPG
7Y0Ak7PXZT37yx/Zla9PzLMJFgbelOkaatdzbblMZPDEVZ27l4lGMmV83Lm3YP17sdAyS/Wp
mav7WmJUkQ9iuIKzSpdc82i9Mfujl1vbBtwtkHNPPtKuulIFM4ZwrPKjlVdLqTSqD8m9yHEi
Y0PuAooq63OpJWF6hvMaiIPBWEAVIaDW9uG0MshLl9DnHnMyrJTfuC33Z9mOGMz7dRBjJd5Y
W02xAzYnUuEBOpj+LQv5R8XIFMHFXktqEKvQrXeM2RU+PcZqKOBkTktxBLn3NI5VfA15Jk0c
5V5XcOqo3p2hvrwvXrinrb2pEREnoqmfrkXT3zOq5Y6ryRH8u734lGEF0dILXzoV4PM7XFit
oTePoEjmMYIFBDCCBQACAQEwgZEwezELMAkGA1UEBhMCVVMxEDAOBgNVBAgMB0Zsb3JpZGEx
GTAXBgNVBAoMEEN1ZGEgU3lzdGVtcyBMTEMxGDAWBgNVBAsMD0N1ZGEgU3lzdGVtcyBDQTEl
MCMGA1UEAwwcQ3VkYSBTeXN0ZW1zIExMQyAyMDE3IEludCBDQQISAsbzIfg9AV1t33FSCanO
XWNfMA0GCWCGSAFlAwQCAwUAoIICQzAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqG
SIb3DQEJBTEPFw0yMzEyMDQxODAwMThaME8GCSqGSIb3DQEJBDFCBECEEF9J+6XfwC/tGrec
e6FpoVtdShr+loOUAUfWifqFC6zXCKCK9jWOb+IClyCYbGImS3K38qdebM9AxI0s90stMGwG
CSqGSIb3DQEJDzFfMF0wCwYJYIZIAWUDBAEqMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzAO
BggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYIKoZIhvcNAwICASgw
gaIGCSsGAQQBgjcQBDGBlDCBkTB7MQswCQYDVQQGEwJVUzEQMA4GA1UECAwHRmxvcmlkYTEZ
MBcGA1UECgwQQ3VkYSBTeXN0ZW1zIExMQzEYMBYGA1UECwwPQ3VkYSBTeXN0ZW1zIENBMSUw
IwYDVQQDDBxDdWRhIFN5c3RlbXMgTExDIDIwMTcgSW50IENBAhICxvMh+D0BXW3fcVIJqc5d
Y18wgaQGCyqGSIb3DQEJEAILMYGUoIGRMHsxCzAJBgNVBAYTAlVTMRAwDgYDVQQIDAdGbG9y
aWRhMRkwFwYDVQQKDBBDdWRhIFN5c3RlbXMgTExDMRgwFgYDVQQLDA9DdWRhIFN5c3RlbXMg
Q0ExJTAjBgNVBAMMHEN1ZGEgU3lzdGVtcyBMTEMgMjAxNyBJbnQgQ0ECEgLG8yH4PQFdbd9x
Ugmpzl1jXzANBgkqhkiG9w0BAQEFAASCAgAPlz9Xubntkh+p0ikR/A2F/l1BmCDJEWZxXxCK
YqiPMM5frL9r+TfQi1haf9ACWOGkHa3kuIGZ8C25YGqijm7Btj2gcFljAkWupvxOCbYYTYEr
djt5xRSwU3nr6pFvYTb11C4w122jIFbloyaStuKcSg9ZNNBD7WV1edk84P1ORVHhVHch77MA
VgkdQ//9bVdQu0+t2Ds05QUvJLNke6fjYuDE1Tjpz9MxMIP2DZp3yAICLSclc9Nnc192+y+x
ZHDC/erlU6jG3e6QzR9kAV5Cim+ZAcjkTbUv0rfzLhShHcEm6H7/otb2h2mu9EdN0fdgBccD
TpU7RwmF8VPwHbcZ6KW96uS2/zEp6u4Zn7nKm/aZh5/sSd9M7NFGX3H8o/Cfrt51+t2zo1Jy
G7dF9UBD9wm7p7Qd+tAbxOKqXAN1n+GW420tgmKl1CrV2SChub8AdiU3q0V9DRAdw8en1zZ+
4kr69sGt+aqGcBAZD3ggJuTyaF5ipVMsaKJhRcQ6s9JIqQguQwrjy57XRIoMZbPdP2a0mw6N
8c6cUgSLNc7rp2m0I8At8RUFtoZ9w6RozAYXQa0MN/uszp5YfDAKOYebySsqDd23mWvwchip
aRls3fCUjD+W67ugUReL6J5R+vRwCzbelp3GhGVGdKUIDO1pggmz59oUUaxe1bK4kNH5DwAA
AAAAAA==
--------------ms020407070906030709080402--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?02ab3650-3e42-4e92-a14f-559d9d3b0b13>