Date: 05 Aug 2002 23:05:50 -0400 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Max Khon <fjoe@FreeBSD.ORG> Cc: gnome@FreeBSD.ORG Subject: Re: gnomemc port Message-ID: <1028603150.25119.5.camel@shumai.marcuscom.com> In-Reply-To: <20020805151616.A17063@hub.freebsd.org> References: <20020805151616.A17063@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-TQyR/HBoYaJN0u7jRzpp
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Mon, 2002-08-05 at 18:16, Max Khon wrote:
> hi, there!
>=20
> please review attached patch. changes are:
>=20
> - specify --with-ncurses correctly
> - properly double '$'
> - ${PERL} -> ${REINPLACE_CMD}
> - handle .zip files correctly (patch-vfs::extfs::uzip)
> - add arrow keys defintions (patch-lib::mc.lib) consistent with
> /usr/ports/misc/mc port
This looks fine. However, what about making the path to unzip LOCALBASE
safe, and switch to using the new GNOMENG framework? That is, add a
line:
USE_GNOMENG=3D yes
And change USE_GNOME=3Dyes to:
USE_GNOME=3D gnomeprefix gnomelibs
Joe
>=20
> /fjoe
> ----
>=20
> ? gnome-mc.Makefile.diff
> Index: Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/ncvs/ports/x11-fm/gnomemc/Makefile,v
> retrieving revision 1.25
> diff -u -p -r1.25 Makefile
> --- Makefile 11 Sep 2001 16:25:07 -0000 1.25
> +++ Makefile 5 Aug 2002 22:09:43 -0000
> @@ -17,15 +17,16 @@ MAINTAINER=3D gnome@FreeBSD.org
> USE_X_PREFIX=3D yes
> USE_GMAKE=3D yes
> USE_GNOME=3D yes
> +USE_REINPLACE=3D yes
> GNU_CONFIGURE=3D yes
> -CONFIGURE_ARGS=3D --without-edit -with-ncurses
> +CONFIGURE_ARGS=3D --without-edit --with-ncurses
> CONFIGURE_ENV=3D CPPFLAGS=3D-I${LOCALBASE}/include \
> LDFLAGS=3D-L${LOCALBASE}/lib
> CONFIGURE_TARGET=3D --target=3D${MACHINE_ARCH}-unknown-freebsd${OSREL}
> =20
> post-patch:
> - @find ${WRKSRC} -name "Makefile.in*" | xargs ${PERL} -pi -e \
> - 's|\$\(libdir\)/mc|\$\(datadir\)/mc|g ; \
> - s|\$\(datadir\)/locale|\$\(prefix\)/share/locale|g'
> + @find ${WRKSRC} -name "Makefile.in*" | xargs ${REINPLACE_CMD} \
> + -e 's|\$$(libdir)/mc|\$$(datadir)/mc|g' \
> + -e 's|\$$(datadir)/locale|\$$(prefix)/share/locale|g'
> =20
> .include <bsd.port.mk>
> ----
>=20
> --- lib/mc.lib.orig Tue Aug 6 03:57:05 2002
> +++ lib/mc.lib Tue Aug 6 03:35:06 2002
> @@ -87,6 +87,16 @@
> end=3D\e[8~
> pgdn=3D\e[6~
> pgup=3D\e[5~
> +up=3D\eOA
> +down=3D\eOB
> +left=3D\eOD
> +right=3D\eOC
> +home=3D\eOH
> +end=3D\eOF
> +delete=3D\e[3~
> +kpplus=3D\eOk
> +kpminus=3D\eOm
> +kpasterix=3D\eOj
> =20
> [terminal:xterm-color]
> insert=3D\e[2~
> @@ -119,6 +129,16 @@
> end=3D\e[8~
> pgdn=3D\e[6~
> pgup=3D\e[5~
> +up=3D\eOA
> +down=3D\eOB
> +left=3D\eOD
> +right=3D\eOC
> +home=3D\eOH
> +end=3D\eOF
> +delete=3D\e[3~
> +kpplus=3D\eOk
> +kpminus=3D\eOm
> +kpasterix=3D\eOj
> =20
> [terminal:ibmpc3]
> f11=3D\e[Y
> ----
>=20
> --- vfs/extfs/uzip.orig Wed Mar 7 18:34:21 2001
> +++ vfs/extfs/uzip Fri Apr 20 12:42:02 2001
> @@ -17,5 +17,5 @@
> # Location of the zip program
> -my $app_zip =3D '/usr/bin/zip';
> +my $app_zip =3D '/usr/local/bin/zip';
> # Location of the unzip program
> -my $app_unzip =3D '/usr/bin/unzip';
> +my $app_unzip =3D '/usr/local/bin/unzip';
> # Set this to 1 if zipinfo (unzip -Z) is to be used (recommended), other=
wise 0.
--=-TQyR/HBoYaJN0u7jRzpp
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)
iD8DBQA9Tz0Ob2iPiv4Uz4cRAswwAKCkd601Ii3+Zg/L39cm/lZ/LY/9pACcDlJS
tl91hHUvOjyEbZjpdwq9NtA=
=w928
-----END PGP SIGNATURE-----
--=-TQyR/HBoYaJN0u7jRzpp--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-gnome" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1028603150.25119.5.camel>