Date: 07 Sep 2002 23:06:14 +0300 From: Ville =?ISO-8859-1?Q?Skytt=E4?= <scop@FreeBSD.org> To: Lance Rushing <lance@lancerushing.com> Cc: freebsd-cvsweb@FreeBSD.org Subject: Re: FW: Unlimited redirect - CGI wrapper / Contribute Code Message-ID: <1031429174.1744.10.camel@bobcat.ods.org> In-Reply-To: <NEBBLHBOGAFGANFIFDEAMEOJCKAA.lance@lancerushing.com> References: <NEBBLHBOGAFGANFIFDEAMEOJCKAA.lance@lancerushing.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2002-09-07 at 11:46, Lance Rushing wrote:
> I modified cvsweb.cgi to work with a cgi wrapper (specifically for a Cobalt
> RaQ4)
>
> Should/Where/How/Who I should contact to add this change to the cvsweb
> project?
Hello Lance, thanks for the patch, the freebsd-cvsweb mailing list is
the correct place.
However, I haven't applied your patch yet, basically because I see it
somewhat hacky, especially the portion of detecting cgiwrap based on
directory/file name. Could you post the full contents of %ENV of
cvsweb.cgi running under cgiwrap, so we could see if there's something
else there to base the detection on?
In case there isn't, I think I will apply this, but add a configuration
variable for enabling that stuff, and default it to false.
> Here is a diff output for the pertinent stuff.
>
> 259a260,262
> > $scriptname = defined($ENV{SCRIPT_NAME}) ? $ENV{SCRIPT_NAME} : '';
> > $scriptname =~ s|^/*|/|;
> 260a264,277
> >
> > my $scriptfilename = defined($ENV{SCRIPT_FILENAME}) ?
> $ENV{SCRIPT_FILENAME} : '';
> > if ($scriptfilename =~ m|^/usr/cgiwrap/cgiwrap$|) {
> > #Example ENV values one cgi wrapper
> > #$ENV{PATH_TRANSLATED} =
> /home/sites/site35/web/cgi-bin/cvsweb-2.0.5/cvsweb.cgi
> > #$ENV{PATH_INFO} = /cgi-bin/cvsweb-2.0.5/cvsweb.cgi/CVSROOT/
> > #$ENV{SCRIPT_NAME} = /cgi-bin/cvsweb-2.0.5/cvsweb.cgi/CVSROOT/
> >
> > my $myname = defined($ENV{PATH_TRANSLATED}) ?
> $ENV{PATH_TRANSLATED} : '';
> > $myname =~ s|^.*/||;
> > $scriptname =~ s|^(.*$myname).*$|$1|;
> > $pathinfo =~ s|$scriptname||;
> > }
> >
> 265,266c282
> < $scriptname = defined($ENV{SCRIPT_NAME}) ? $ENV{SCRIPT_NAME} : '';
> < $scriptname =~ s|^/*|/|;
Cheers,
--
\/ille Skyttä
scop at FreeBSD.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-cvsweb" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1031429174.1744.10.camel>