Skip site navigation (1)Skip section navigation (2)
Date:      18 Jan 2003 18:17:30 -0500
From:      Joe Marcus Clarke <marcus@marcuscom.com>
To:        Mark Hannon <markhannon@optusnet.com.au>
Cc:        FreeBSD GNOME Users <gnome@freebsd.org>
Subject:   Re: ports/37136: Gdm package sets wrong permissions
Message-ID:  <1042931850.7820.45.camel@shumai.marcuscom.com>
In-Reply-To: <3E293028.40002@optusnet.com.au>
References:  <200301161200.h0GC0R2N016040@freefall.freebsd.org> <1042740239.324.49.camel@gyros>  <3E293028.40002@optusnet.com.au>

next in thread | previous in thread | raw e-mail | index | archive | help

--=-88mtH+nzhw8zCQ16BAvP
Content-Type: multipart/mixed; boundary="=-djzI137pSnicue6gxqKA"


--=-djzI137pSnicue6gxqKA
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sat, 2003-01-18 at 05:44, Mark Hannon wrote:
> Joe Marcus Clarke wrote:
>=20
> >On Thu, 2003-01-16 at 07:00, Mark Hannon wrote:
> > =20
> >
> >> Hi,
> >>=20
> >> Installed 5.0-RC2 and the gnome packages on the CD-ROM this morning. =20
> >> The same problem exists.  Any ideas?
> >>   =20
> >>
> >
> >This looks like a packaging problem.  The port explicitly chmod's the
> >directory to 0750.  Alternatively, what is your root's umask?
> >
> > =20
> >
> Hmmm ... I think I have withheld a vital clue :-[   Before getting the=20
> message
> re: incorrect permissions I get a message about wrong directory owner, th=
e
> directory was owned by root/wheel and I needed to chown gdm:gdm it.
>=20
> The directory was installed by:
>=20
> tbird:~> sudo pkg_info -W /usr/X11R6/share/gnome/gdm/.keep_me
> /usr/X11R6/share/gnome/gdm/.keep_me was installed by package gnomehier-1.=
0_4
>=20
> and presumably this port does not have any knowledge of gdm:gdm.  Maybe=20
> the fix is
> to add the gdm uid and gid to the gnomehier port?
>=20
> FWIW, my umask is either 2 or 22 (I have never realized before that sudo=20
> uses a different umask then my normal uid and indeed a full su root).

I think I see the problem.  It looks to be a limitation in the package
building system regarding directories.  All the files retain the correct
version, but the directories do not.  Attached is a patch that should
fix the problem.  If you would like to test, please do the following:

# pkg_delete -f gdm2\*
# cd /usr/ports/x11
# patch -p < /path/to/gdm2.diff
# cd /usr/ports/x11/gdm2
# make package
# make deinstall
# rm -rf /usr/X11R6/share/gnome/gdm
# pkg_add gdm2-2.4.0.12

The resulting /usr/X11R6/share/gnome/gdm should have the correct
permissions.

Joe

>=20
> rgds/mark
--=20
PGP Key : http://www.marcuscom.com/pgp.asc

--=-djzI137pSnicue6gxqKA
Content-Disposition: attachment; filename=gdm2.diff
Content-Transfer-Encoding: quoted-printable
Content-Type: text/x-patch; name=gdm2.diff; charset=ISO-8859-1

diff -ruN gdm2.orig/Makefile gdm2/Makefile
--- gdm2.orig/Makefile	Sat Jan 18 18:14:03 2003
+++ gdm2/Makefile	Sat Jan 18 18:11:40 2003
@@ -61,12 +61,6 @@
 	@${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
 .endif
 	@${INSTALL_SCRIPT} ${WRKSRC}/gdm.sh.sample ${PREFIX}/etc/rc.d
-.if !defined(BATCH) && !defined(PACKAGE_BUILDING)
-	@${CHOWN} -R gdm:gdm ${PREFIX}/share/gnome/gdm ${PREFIX}/etc/gdm
-.else
-	@${CHOWN} -R 92:92 ${PREFIX}/share/gnome/gdm ${PREFIX}/etc/gdm
-.endif
-	@${CHMOD} 0750 ${PREFIX}/share/gnome/gdm
 	@${CAT} ${PKGMESSAGE}
=20
 .include <bsd.port.post.mk>
diff -ruN gdm2.orig/pkg-install gdm2/pkg-install
--- gdm2.orig/pkg-install	Sat Jan 18 18:14:03 2003
+++ gdm2/pkg-install	Sat Jan 18 18:12:39 2003
@@ -10,6 +10,8 @@
 	UID=3D92
 	GID=3D${UID}
 	PW=3D/usr/sbin/pw
+	CHMOD=3D/bin/chmod
+	CHOWN=3D/usr/sbin/chown
=20
 	if ${PW} group show "${GROUP}" 2>/dev/null; then
 		echo "You already have a group \"${GROUP}\", so I will use it."
@@ -34,6 +36,8 @@
 			exit 1
 		fi
 	fi
+	${CHOWN} -R ${USER}:${GROUP} ${PKG_PREFIX}/share/gnome/gdm ${PKG_PREFIX}/=
etc/gdm
+	${CHMOD} 0750 ${PKG_PREFIX}/share/gnome/gdm
 	exit 0
 fi
=20

--=-djzI137pSnicue6gxqKA--

--=-88mtH+nzhw8zCQ16BAvP
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQA+KeCKb2iPiv4Uz4cRAmEjAJ450HU9Fr49jNmFUEYacQdmFn7oPwCgkyno
dDoFRFOj7Db2hKqK2+5J9Wk=
=wRZx
-----END PGP SIGNATURE-----

--=-88mtH+nzhw8zCQ16BAvP--


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-gnome" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1042931850.7820.45.camel>