Date: Sun, 29 Feb 2004 18:09:44 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: "Brandon D. Valentine" <ports@brandon.dvalentine.com> Cc: freebsd-ports-bugs@freebsd.org Subject: Re: ports/63545: Today's portupgrade of linux-flashplugin to FreeBSD-4.9Stable Message-ID: <1078096184.62463.44.camel@shumai.marcuscom.com> In-Reply-To: <200402292300.i1TN0ZSJ039160@freefall.freebsd.org> References: <200402292300.i1TN0ZSJ039160@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-PcKUhMq52mwqx6JvQZ45
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Sun, 2004-02-29 at 18:00, Brandon D. Valentine wrote:
> The following reply was made to PR ports/63545; it has been noted by GNAT=
S.
>=20
> From: "Brandon D. Valentine" <ports@brandon.dvalentine.com>
> To: Jeremy Messenger <mezz7@cox.net>
> Cc: freebsd-gnats-submit@FreeBSD.org, stacey@vickiandstacey.com
> Subject: Re: ports/63545: Today's portupgrade of linux-flashplugin to lin=
ux-flashplugin-6.0r79_1 breaks flash for linux-opera on FreeBSD-4.9Stable
> Date: Sun, 29 Feb 2004 16:50:54 -0600
>=20
> On Sun, Feb 29, 2004 at 04:34:26PM -0600, Jeremy Messenger wrote:
> > Actually, you can't do the define PLUGINSDIR because there's no "?" in=
it.
> >=20
> > PLUGINSDIR?=3D
> =20
> Hmm, you're right. I will include that change in the patch I am working
> on.
> =20
> The problem I'm running into is I don't seem to get variable expansion
> to work inside my conditional.
> =20
> This works:
> =20
> .for f in ${LIBFILES}
> @${INSTALL_DATA} ${WRKSRC}/${f} ${PREFIX}/lib/linux-flashplugin6
> .if exists(/usr/local/lib/linux-mozilla/plugins)
> echo "Hi! I'm inside the if statement!"
> @${LN} -sf ${PREFIX}/lib/linux-flashplugin6/${f}
> ${PREFIX}/${PLUGINSDIR}
> .endif
> .endfor
> =20
> This doesn't:
> =20
> .for f in ${LIBFILES}
> @${INSTALL_DATA} ${WRKSRC}/${f} ${PREFIX}/lib/linux-flashplugin6
> .if exists(${PREFIX}/${PLUGINSDIR})
> echo "Hi! I'm inside the if statement!"
> @${LN} -sf ${PREFIX}/lib/linux-flashplugin6/${f}
> ${PREFIX}/${PLUGINSDIR}
> .endif
> .endfor
> =20
> And I'm not sure why it doesn't work. At any rate, I have a solution
> and with a bit more testing I'll submit a new patch.
Convert this make conditional into a shell script conditional, and it
will work:
@for f in ${LIBFILES}; do \
${INSTALL_DATA} ${WRKSRC}/$${f} \ ${PREFIX}/lib/linux-flashplugin6;
\
if [ -d ${PREFIX}/${PLUGINSDIR} ]; then \
echo "Hi! I'm inside the if statement!"; \
${LN} -sf \ ${PREFIX}/lib/linux-flashplugin6/$${f}; \
fi; \
done
You never want to use exists on a directory anyway.
Joe
> =20
> Sorry for the inconvenience,
> =20
> Brandon D. Valentine
> --=20
> brandon@dvalentine.com http://www.geekpunk.net
> Pseudo-Random Googlism: tejas is mccarley's way of continuing his
> family's texas traditions
> _______________________________________________
> freebsd-ports-bugs@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
> To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.=
org"
--=20
PGP Key : http://www.marcuscom.com/pgp.asc
--=-PcKUhMq52mwqx6JvQZ45
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQBAQnE4b2iPiv4Uz4cRAt/NAJ9OTEvoMAErvvse8OcpIH1HTAFQ4wCaAxsP
DW8oUsoyCdQFiP+3/I5CdWg=
=L3hw
-----END PGP SIGNATURE-----
--=-PcKUhMq52mwqx6JvQZ45--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1078096184.62463.44.camel>