Date: Sun, 29 Feb 2004 18:14:09 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: "Brandon D. Valentine" <ports@brandon.dvalentine.com> Cc: freebsd-ports-bugs@freebsd.org Subject: Re: ports/63545: Today's portupgrade of linux-flashplugin to FreeBSD-4.9Stable Message-ID: <1078096449.62463.46.camel@shumai.marcuscom.com> In-Reply-To: <1078096184.62463.44.camel@shumai.marcuscom.com> References: <200402292300.i1TN0ZSJ039160@freefall.freebsd.org> <1078096184.62463.44.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-accBdJ4Dc9ZHZWcfF0y1 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun, 2004-02-29 at 18:09, Joe Marcus Clarke wrote: > On Sun, 2004-02-29 at 18:00, Brandon D. Valentine wrote: > > The following reply was made to PR ports/63545; it has been noted by GN= ATS. > >=20 > > From: "Brandon D. Valentine" <ports@brandon.dvalentine.com> > > To: Jeremy Messenger <mezz7@cox.net> > > Cc: freebsd-gnats-submit@FreeBSD.org, stacey@vickiandstacey.com > > Subject: Re: ports/63545: Today's portupgrade of linux-flashplugin to l= inux-flashplugin-6.0r79_1 breaks flash for linux-opera on FreeBSD-4.9Stable > > Date: Sun, 29 Feb 2004 16:50:54 -0600 > >=20 > > On Sun, Feb 29, 2004 at 04:34:26PM -0600, Jeremy Messenger wrote: > > > Actually, you can't do the define PLUGINSDIR because there's no "?" = in it. > > >=20 > > > PLUGINSDIR?=3D > > =20 > > Hmm, you're right. I will include that change in the patch I am worki= ng > > on. > > =20 > > The problem I'm running into is I don't seem to get variable expansion > > to work inside my conditional. > > =20 > > This works: > > =20 > > .for f in ${LIBFILES} > > @${INSTALL_DATA} ${WRKSRC}/${f} ${PREFIX}/lib/linux-flashplugin6 > > .if exists(/usr/local/lib/linux-mozilla/plugins) > > echo "Hi! I'm inside the if statement!" > > @${LN} -sf ${PREFIX}/lib/linux-flashplugin6/${f} > > ${PREFIX}/${PLUGINSDIR} > > .endif > > .endfor > > =20 > > This doesn't: > > =20 > > .for f in ${LIBFILES} > > @${INSTALL_DATA} ${WRKSRC}/${f} ${PREFIX}/lib/linux-flashplugin6 > > .if exists(${PREFIX}/${PLUGINSDIR}) > > echo "Hi! I'm inside the if statement!" > > @${LN} -sf ${PREFIX}/lib/linux-flashplugin6/${f} > > ${PREFIX}/${PLUGINSDIR} > > .endif > > .endfor > > =20 > > And I'm not sure why it doesn't work. At any rate, I have a solution > > and with a bit more testing I'll submit a new patch. >=20 > Convert this make conditional into a shell script conditional, and it > will work: >=20 > @for f in ${LIBFILES}; do \ > ${INSTALL_DATA} ${WRKSRC}/$${f} \ ${PREFIX}/lib/linux-flashplugin6; > \ > if [ -d ${PREFIX}/${PLUGINSDIR} ]; then \ > echo "Hi! I'm inside the if statement!"; \ > ${LN} -sf \ ${PREFIX}/lib/linux-flashplugin6/$${f}; \ > fi; \ > done >=20 > You never want to use exists on a directory anyway. I forgot to add, you will want to also do: .include <bsd.port.pre.mk> Before your targets so that variable expansion works as expected. Joe >=20 > Joe >=20 > > =20 > > Sorry for the inconvenience, > > =20 > > Brandon D. Valentine > > --=20 > > brandon@dvalentine.com http://www.geekpunk.n= et > > Pseudo-Random Googlism: tejas is mccarley's way of continuing his > > family's texas traditions > > _______________________________________________ > > freebsd-ports-bugs@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs > > To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebs= d.org" --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-accBdJ4Dc9ZHZWcfF0y1 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAQnJBb2iPiv4Uz4cRAu6iAJ97eNO0XKO6K38nAVgr3cneJsiahgCfZyzN ibU2AXPvKgSE9Wovs45wYx4= =UslP -----END PGP SIGNATURE----- --=-accBdJ4Dc9ZHZWcfF0y1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1078096449.62463.46.camel>