Date: Tue, 25 Jan 2005 20:55:07 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Michael Sierchio <kudzu@tenebras.com> Cc: lioux@freebsd.org Subject: Re: FreeBSD Port: qmail-1.03_3 Message-ID: <1106704507.16118.14.camel@shumai.marcuscom.com> In-Reply-To: <41F6F431.6060005@tenebras.com> References: <41F6F431.6060005@tenebras.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-wA1VovY74EQS2PpMympg Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2005-01-25 at 17:36 -0800, Michael Sierchio wrote: > You have added a patch which is totally unneccesary, and I > suggest that it be removed: >=20 > in your patch-qmail-local.... >=20 > - while ((k > i) && (cmds.s[k - 1] =3D=3D ' ') || (cmds.s[k - 1] =3D= =3D '\t')) > + while ((k > i) && ((cmds.s[k - 1] =3D=3D ' ') || (cmds.s[k - 1] =3D= =3D '\t'))) >=20 > This is totally bogus, the original code is correct. Please do not > make changes to contributed code simply because it makes it easier > for you to understand. There is no semantic difference between the > two, ERGO the patch should not exist. Please remove it. Actually, if k is less than or equal to i and cmds.s[k-1] is a tab, then the first bit of code evaluates to true while the second evaluates to false. I haven't looked at the rest of the code, but those statements are semantically different, and I think the second is more correct. Joe >=20 > Shall I file a PR? >=20 >=20 > - Michael >=20 >=20 > _______________________________________________ > freebsd-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" >=20 --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-wA1VovY74EQS2PpMympg Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQBB9vh7b2iPiv4Uz4cRAoM3AJ9+EkEVd95nHgQ5gOswfBnDrI+GnwCaA5m1 1et7i0471Yez8Hzy7kYKSjk= =cFRw -----END PGP SIGNATURE----- --=-wA1VovY74EQS2PpMympg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1106704507.16118.14.camel>