Date: Wed, 21 Feb 2001 14:03:50 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Ben Smithurst <ben@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 style.9 Message-ID: <1166.982760630@critter> In-Reply-To: Your message of "Wed, 21 Feb 2001 04:10:19 PST." <200102211210.f1LCAKN41997@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200102211210.f1LCAKN41997@freefall.freebsd.org>, Ben Smithurst writes: >ben 2001/02/21 04:10:19 PST > > Modified files: > share/man/man9 style.9 > Log: > Don't suggest > > if (error = function(a1, a2)) > > since it causes a warning with -Wall. Change it so it has an explicit test > against zero, > > if ((error = function(a1, a2)) != 0) Better, and more readable: error = function(a1, a2); if (error != 0) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1166.982760630>