Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Jul 1995 00:51:56 +0100
From:      Gary Palmer <gary@palmer.demon.co.uk>
To:        Frank Bartels <knarf@nasim.cube.net>
Cc:        freebsd-ports@freebsd.org
Subject:   Re: diffs and checksums 
Message-ID:  <1223.805679516@palmer.demon.co.uk>
In-Reply-To: Your message of "13 Jul 1995 23:46:00 %2B0200." <3u446o$oih@nasim.nasim.cube.net> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <3u446o$oih@nasim.nasim.cube.net>, Frank Bartels writes:
>Hi!
>
>I always wondered why all the patches are context and not unified
>diffs.  Unified diffs are much more readable and easier to edit. I
>always read the diffs before doing the make and I sometimes disagree
>with some (configuration) settings and want to edit the patches.

The type of diff supplied in a port is extremely dependant on the
person doing the port - I prefer context diffs, and tend to use them,
even if I am working on an existing port which uses a different diff
format - I find context diffs a lot easier for ports as you get a
better idea of what is actually being changed as you have the context
of the patch...

>It also would be a good idea to have an additional md5 file for the
>_uncompressed_ original archive. I really *hate* compress (.Z) and I
>always do a znew on these files but this leads into checksum mismatch.
>I usually get the distfiles from my own public archive and it would be
>nice to look for .tar.gz if EXTRACT_SUFX is .tar.Z and then check
>something like files/tar.md5 instead of files/md5.

Seeing as the plain tar file is never seen by the ports mechanism, you
are suggesting we add another step? Currently we go straight from the
tarball to the extracted source, so there is no real way to check the
md5 of the tar file.

Also, if the file starts as a .Z, you do a znew, surely you get a file
with a .gz extension? That shouldn't produce a checksum mismatch, you
should be told that it can't find a checksum to match against that
file (I can't remember what it says, but it's not a checksum
mismatch!)

Gary




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1223.805679516>