Date: Fri, 27 Mar 2009 08:40:14 +0100 From: Pav Lucistnik <pav@FreeBSD.org> To: Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: ports@FreeBSD.org Subject: Re: HEADS UP multi processor compilations for everyone Message-ID: <1238139614.71596.2.camel@hood.oook.cz> In-Reply-To: <20090327010223.GK1964@hades.panopticon> References: <1237901632.1849.19.camel@pav.hide.vol.cz> <20090326174632.GB19722@hades.panopticon> <1238108060.268.1.camel@hood.oook.cz> <20090327010223.GK1964@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-Qy/+8n7fcKoau50cCKmZ
Content-Type: text/plain; charset="ISO-8859-2"
Content-Transfer-Encoding: quoted-printable
Dmitry Marakasov p=ED=B9e v p=E1 27. 03. 2009 v 04:02 +0300:
> * Pav Lucistnik (pav@FreeBSD.org) wrote:
>=20
> > > Btw, this change broke build failures. If vendor's make fails,
> > > .build_done.xxx._usr_local is still created in work and $? =3D 0 as i=
f it
> > > have succeeded.
> >=20
> > Can you give me a hard example?
>=20
> Test port consisting of a sole Makefile attached.
>=20
> I've made two patches for bsd.port.mk.
> First one fixes this issue by adding some false's to do-build,=20
Ah right, I have stolen do-configure targets and missed the ${FALSE}.
Will fix.
> second
> also improves MAKE_JOBS_* handling, shortening it a bit and exposing
> MAKE_JOBS_NUMBER to the ports, so it can be used for other build systems
> without having to parse out -j from _MAKE_JOBS (and defaults to 1 if
> jobs support is disabled).
This one I cannot accept, because it adds back !=3D call I made a big
effort to avoid. We can't have one !=3D call per port during building
INDEX.
> Also, [ x !=3D x${BUILD_FAIL_MESSAGE} ] thing seems to be a bit unsafe,
> and inconsistent to IGNORE/BROKEN/... vars, in which we don't use
> quotes.
It's consistent with CONFIGURE_FAIL_MESSAGE. Why are you removing the
parenthesis around the ${ECHO_CMD} ${BUILD_FAIL_MESSAGE}, BTW?
Because they are present in do-configure target too - should they be
removed there too?
--=20
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
Pain clots and unformed lice pat this train.
--=-Qy/+8n7fcKoau50cCKmZ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
=?ISO-8859-1?Q?_zpr=E1vy?=
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEABECAAYFAknMgtoACgkQntdYP8FOsoJSkwCguM+HZoY3TCMWtvK3W5o2ZiJ9
OZcAn0pnhvN7PBbHcuarT/qDbpATc2gn
=gg5T
-----END PGP SIGNATURE-----
--=-Qy/+8n7fcKoau50cCKmZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1238139614.71596.2.camel>