Date: Sun, 24 May 2009 18:27:57 +0200 From: Pav Lucistnik <pav@FreeBSD.org> To: Ion-Mihai Tetcu <itetcu@FreeBSD.org> Cc: pgollucci@p6m7g8.com, naylor.b.david@gmail.com, freebsd-ports@FreeBSD.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) Message-ID: <1243182477.18007.18.camel@hood.oook.cz> In-Reply-To: <20090524190131.0b30b101@it.buh.tecnik93.com> References: <20090522.195350.193746535.chat95@mac.com> <20090522164138.236cb114@it.buh.tecnik93.com> <200905231101.59467.naylor.b.david@gmail.com> <20090523.182426.193741786.chat95@mac.com> <20090523135133.71a92669@it.buh.tecnik93.com> <1243174223.18007.2.camel@hood.oook.cz> <20090524190131.0b30b101@it.buh.tecnik93.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-nIKWlqIVLrOmVK6xVCOI
Content-Type: text/plain; charset="ISO-8859-2"
Content-Transfer-Encoding: quoted-printable
Ion-Mihai Tetcu p=ED=B9e v ne 24. 05. 2009 v 19:01 +0300:
> On Sun, 24 May 2009 16:10:23 +0200
> Pav Lucistnik <pav@FreeBSD.org> wrote:
>=20
> > Ion-Mihai Tetcu p=ED=B9e v so 23. 05. 2009 v 13:51 +0300:
> >=20
> > > > > - MAKE_JOBS_NUMBER defaults (but user defined) to number of
> > > > > cores
> > >=20
> > > This part looks OK, I wonder if there's any reason t ain't like this
> > > now; Pav?
> > > -.if defined(MAKE_JOBS_NUMBER)
> > > +MAKE_JOBS_NUMBER?=3D `${SYSCTL} -n kern.smp.cpus`
> > > _MAKE_JOBS=3D -j${MAKE_JOBS_NUMBER}
> > > -.else
> > > -_MAKE_JOBS=3D -j`${SYSCTL} -n kern.smp.cpus`
> > > -.endif
> >=20
> > Wouldn't that mean an evaluation of the backtick command in every
> > make(1) invocation? That would be highly undesirable.
>=20
> Umm, why? it shouldn't be evaluated if MAKE_JOBS_NUMBER is defined, no?
> Am I missing some make magic here?
But for 99.99% of the users, MAKE_JOBS_NUMBER is not defined.
--=20
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
... the obese drugged penguin used by Linux. -- Scott Long
--=-nIKWlqIVLrOmVK6xVCOI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
=?ISO-8859-1?Q?_zpr=E1vy?=
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEABECAAYFAkoZdY0ACgkQntdYP8FOsoKUqQCfSPfbVQvN1IEAE9GZ5WP+eoG6
JqoAn0+iFUpBDjBH+dO0+Hl2BXz8cH2p
=05gn
-----END PGP SIGNATURE-----
--=-nIKWlqIVLrOmVK6xVCOI--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1243182477.18007.18.camel>