Date: Sun, 19 Sep 1999 00:10:36 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Julian Elischer <julian@whistle.com> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vn vn.c Message-ID: <13144.937692636@critter.freebsd.dk> In-Reply-To: Your message of "Sat, 18 Sep 1999 15:02:39 PDT." <Pine.BSF.4.05.9909181455490.19879-100000@home.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <Pine.BSF.4.05.9909181455490.19879-100000@home.elischer.org>, Julian Elischer writes: >Poul-Henning, since Matt (who is working on this driver) STATED that he >didn't want you to do this, why did you do it anyway? Uhm, I read your last message as your approval for this... >If you want to do this right.. > >Move the calculation of blocksize in spec_read and spec_write >to spec_open, and store the value in to si_bsize_best if it's still unset, >and then in read/write just blindly use _best, instead of doing the >calculation on every read and write. I think si_bsize_best should not even be used in spec_read/_write. I think they should blindly use max(PAGE_SIZE, si_bsize_phys). -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13144.937692636>