Date: Sun, 20 Oct 2013 23:55:05 -0400 From: Sean Bruno <sean_bruno@yahoo.com> To: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> Subject: gperf -- #define for if (0) ; else for Message-ID: <1382327705.2610.9.camel@localhost>
next in thread | raw e-mail | index | archive | help
--=-SA48uZOt/F4H/9FUwr1p
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
I don't even know why this is a thing in our code base. Its generating
a lot of clang noise due to -Wdangling-else
/usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/src/search.cc:417:15:
warning: add explicit braces to avoid dangling else [-Wdangling-else]
for (int i3 =3D imax; i3 >=3D 0; i3--)
^
/usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/src/search.cc:39:22:
note: expanded from macro 'for'
#define for if (0) ; else for
^
I see no reason to continue this and propose the removal of the line in
contrib/gperf/src/search.cc=20
37
38 /* Assume ISO C++ 'for' scoping rule. */
39 #define for if (0) ; else for
--=-SA48uZOt/F4H/9FUwr1p
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)
iQEcBAABAgAGBQJSZKWZAAoJEBkJRdwI6BaH6FcH/A/LCXTq/1M1VBCJtsxLzFJ0
U2W6PpjdgDjwtsWdJCHoiFpyp8LCuYKfKRYkbk79dljWBwnMksA6RFfCop8qVcXM
K+d7EwRjLyaFAenatAs/i0V7MAed7ajJERFejoCP271X+VzOg0Z1bhpGMiU8tC2Z
hEz2dR7f1KLkkBGutQ/XV5GQB1fI0AcA1NyNTcfVXHpNe+NgBh6Lavd4+LDf9uQ5
1UTR88ZqsE6OeP+4LWf60vlPWZTHlmyjsiqM0LJ0nIJF9vazw5frI+BpOhf7FdB4
MQhA34ip2HtnlKqVA1DPoUCedQjyQ0nkG7yns2PgvFeTvVoGvEhvz4GHfLGdOm0=
=8JJa
-----END PGP SIGNATURE-----
--=-SA48uZOt/F4H/9FUwr1p--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1382327705.2610.9.camel>