Date: Fri, 25 Oct 2013 06:38:43 -0400 From: David Chisnall <theraven@FreeBSD.org> To: sbruno@FreeBSD.org Cc: Matthew Fleming <mdf@FreeBSD.org>, "freebsd-current@freebsd.org" <freebsd-current@FreeBSD.org> Subject: Re: gperf/src/options.cc -- quiesce clang warnings -Wlogical-op-parentheses Message-ID: <14061B35-A258-4368-BECD-9934CF594AE1@FreeBSD.org> In-Reply-To: <1382665803.2498.13.camel@localhost> References: <1382327452.2610.5.camel@localhost> <1382399026.7749.3.camel@localhost> <0744E30D-89EF-4340-A7DC-968AC27F302B@FreeBSD.org> <1382663626.2498.4.camel@localhost> <3656E3A3-F76E-42F4-BCFC-8B0F49FF5DA9@FreeBSD.org> <1382665803.2498.13.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
On 24 Oct 2013, at 21:50, Sean Bruno <sean_bruno@yahoo.com> wrote: > On Thu, 2013-10-24 at 21:24 -0400, David Chisnall wrote: >>=20 >> Don't forget the freelocale() at the end. >>=20 > ah, ok. I wish that there was some kind of example that I could go = off > of in the man page. I'm sort of trundling my way through various bits > of the system to find the obvious example of how to do this correctly. >=20 >> This seems like a very slow way of doing what was very fast in the >> original code though. I'm not entirely sure what you're aiming to >> gain in this refactoring. >>=20 >> David >>=20 >>=20 >=20 > I'm simply trying to address the warnings that appear due to clang. I > find the builds very noisy and if there's a better way to address this > issue, I'm totally open to suggestions. Well, for contrib code that isn't going to be around for much longer = like gperf, the best thing to do is probably just stick = -Wno-logical-op-parentheses in the CFLAGS. Alternatively, adding the = brackets as it suggested to indicate precedence is simple. David
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14061B35-A258-4368-BECD-9934CF594AE1>