Date: Fri, 29 Aug 2014 07:58:36 -0600 From: Ian Lepore <ian@FreeBSD.org> To: Michael Tuexen <tuexen@freebsd.org> Cc: "freebsd-arm@freebsd.org" <arm@freebsd.org> Subject: Re: Problem running make_dtb.sh Message-ID: <1409320716.1150.169.camel@revolution.hippie.lan> In-Reply-To: <F06A8E2E-EEDE-4767-85EF-2834ECF547D2@freebsd.org> References: <F06A8E2E-EEDE-4767-85EF-2834ECF547D2@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-mzIiZcdXs5Wta0bkDBIO Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, 2014-08-29 at 14:44 +0200, Michael Tuexen wrote: > Dear all, > > when trying to build the kernel on a Wandboard the traditional way as described in > https://www.freebsd.org/doc/en/books/developers-handbook/kernelbuild.html#kernelbuild-traditional > a make results in > ... > sh ../../../tools/fdt/make_dtb.sh ../../.. wandboard-quad.dts /usr/home/tuexen/sys/arm/compile/WANDBOARD-QUAD > converting wandboard-quad.dts -> /usr/home/tuexen/sys/arm/compile/WANDBOARD-QUAD/wandboard-quad.dtb > <built-in>:159:10: fatal error: 'wandboard-quad.dts' file not found > #include "wandboard-quad.dts" > ^ > 1 error generated. > Error: <stdin>:1.1-2.1 syntax error > FATAL ERROR: Unable to parse input tree > *** Error code 1 > > Stop. > > The reason is that make_dtb.sh uses $MACHINE which is not set. If I set it to arm, the make completes > successfully. How is this fixed in the best way? > > Best regards > Michael IMO, the best way to fix it would be to update the handbook to say that the "traditional" way of building a kernel is no longer supported. Since that won't fly due to a small but very vocal minority, maybe the attached patch would be a good fix. -- Ian --=-mzIiZcdXs5Wta0bkDBIO Content-Disposition: inline; filename="make_dtb_machine.diff" Content-Type: text/x-patch; name="make_dtb_machine.diff"; charset="us-ascii" Content-Transfer-Encoding: 7bit Index: sys/tools/fdt/make_dtb.sh =================================================================== --- sys/tools/fdt/make_dtb.sh (revision 270064) +++ sys/tools/fdt/make_dtb.sh (working copy) @@ -12,6 +12,10 @@ if [ -z "$dts" ]; then exit 1 fi +if [ -z "${MACHINE}" ]; then + MACHINE=$(uname -m) +fi + for d in ${dts}; do dtb=${dtb_path}/`basename $d .dts`.dtb echo "converting $d -> $dtb" --=-mzIiZcdXs5Wta0bkDBIO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1409320716.1150.169.camel>