Date: Tue, 22 Aug 2006 11:03:42 +0200 From: Daniel Gerzo <danger@FreeBSD.org> To: doc@freebsd.org Subject: merge query-pr.cgi and query-pr-summary.cgi, fix -T mode with new perl Message-ID: <1418203821.20060822110342@rulez.sk>
next in thread | raw e-mail | index | archive | help
------------473519D314CD620 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Hello doc, I have produced a patch [1] which combines two cgi scripts -- query-pr.cgi and query-pr-summary.cgi. It merges functionality of query-pr.cgi into -summary.cgi, but if we want to commit this I would recommend to rename query-pr-summary.cgi to query-pr.cgi (maybe symlink would be even better?) once commited. Patched version is available at [2]. I made it to display the query form by default and not the list all open PRs. This should at least a bit unburten GNATS. (note that the html we generate now has around 1.3MB when one is accessing query-pr-summary.cgi). I also fixed this script to be able to run in tainted mode. (I'm not sure if we should call die() if insecure data are passed, or just ignore the given filter) I would like you to review this patch. The only drawback I can see is that the query-pr-summary.cgi?prnumber does not work with new version. It is required to do query-pr-summary.cgi?pr=3Dprnumber (which was standard for original version). [1] http://people.freebsd.org/~danger/query-pr.diff [2] http://people.freebsd.org/~danger/cgi/query-pr-summary.cgi --=20 Best regards, Daniel mailto:danger@FreeBSD.org ------------473519D314CD620 Content-Type: application/pgp-signature -----BEGIN PGP MESSAGE----- Version: GnuPG v1.4.5 (MingW32) iD8DBQFE6shupjhloOLa1gsRAhq3AJ0ZWXQLDjG1h8A7w7Pc5XU1tQ5IJwCfdXZP ozZGAZWYVt7uhAsc8sM+q0w= =9SG/ -----END PGP MESSAGE----- ------------473519D314CD620--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1418203821.20060822110342>