Date: Wed, 18 Sep 2013 20:05:39 -0400 (EDT) From: Rick Macklem <rmacklem@uoguelph.ca> To: Devin Teske <Devin.Teske@fisglobal.com> Cc: freebsd-fs <freebsd-fs@FreeBSD.org> Subject: Re: kern/182181: [ufs] Leakage of vnode references (race condition?) Message-ID: <1480665076.26305077.1379549139533.JavaMail.root@uoguelph.ca> In-Reply-To: <13CA24D6AB415D428143D44749F57D720FBD7904@LTCFISWMSGMB21.FNFIS.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Devin Teske wrote: > > On Sep 18, 2013, at 4:00 PM, Oleksandr V. Typlyns'kyi wrote: > > > Devin, i think line 1266 in HEAD - it is line 1245 in 8-STABLE: > > http://svnweb.freebsd.org/base/head/sys/ufs/ufs/ufs_vnops.c?annotate=253998#l1266 > > http://svnweb.freebsd.org/base/stable/8/sys/ufs/ufs/ufs_vnops.c?annotate=248832#l1245 > > http://svnweb.freebsd.org/base/releng/8.4/sys/ufs/ufs/ufs_vnops.c?annotate=248833#l1245 > > And it was not MFC'ed > > Yes, my confusion was... > > 1. The PR headers say 8.4-RELEASE-p3 is affected > > 2. The PR's "How-To-Repeat" starts with "Install a releng/8.4 branch" > > Yet... > > releng/8.4 and even releng/8.3 both use VOP_UNLOCK instead of vput > (read: are patched). > Did you mean "not patched"? The patched version in head has vput() and the unpatched versions have VOP_UNLOCK(), if I read the coed correctly. rick > So I'm very curious, with respect to the PR, how the test program > showed > a leak when the claim is that r253998 which fixes this, was in the > OP's branch. > -- > Devin > > _____________ > The information contained in this message is proprietary and/or > confidential. If you are not the intended recipient, please: (i) > delete the message and all copies; (ii) do not disclose, distribute > or use the message in any manner; and (iii) notify the sender > immediately. In addition, please be aware that any message addressed > to our domain is subject to archiving and review by persons other > than the intended recipient. Thank you. > _______________________________________________ > freebsd-fs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1480665076.26305077.1379549139533.JavaMail.root>