Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 8 Oct 2024 17:16:49 +0200 (CEST)
From:      Ronald Klop <ronald-lists@klop.ws>
To:        Piotr Smyrak <ps.ports@smyrak.com>
Cc:        ports@freebsd.org
Subject:   Re: what to do about "FATAL: PLIST_FILES: files cannot contain %%FOO%% variables.  Use make variables and logic instead"
Message-ID:  <1718369388.9678.1728400609900@localhost>
In-Reply-To: <20241008144819.34c3803c@daleth.home>
References:  <722318548.6969.1728390863107@localhost> <20241008144819.34c3803c@daleth.home>
next in thread | previous in thread | raw e-mail | index | archive | help 
------=_Part_9677_535086113.1728400609858
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Van: Piotr Smyrak <ps.ports@smyrak.com>
Datum: dinsdag, 8 oktober 2024 14:48
Aan: ports@freebsd.org
Onderwerp: Re: what to do about "FATAL: PLIST_FILES: files cannot contain %%FOO%% variables. Use make variables and logic instead"
> 
> On Tue, 8 Oct 2024 14:34:23 +0200 (CEST)
> Ronald Klop <ronald-lists@klop.ws> wrote:
> 
> > I was looking for a change to devel/jna and after running portlint it
> > says:
> >
> > FATAL: PLIST_FILES: files cannot contain %%FOO%% variables.  Use make
> > variables and logic instead
> >
> > The lines in the Makefile this is about are:
> > PLIST_FILES=    %%JAVAJARDIR%%/jna-platform.jar \
> >                 %%JAVAJARDIR%%/jna.jar
> >
> > What would be the proper solution for this?
> 
> See x11-fonts/iansui Makefile for an example.
> 
> HTH,
> -- 
>  Piotr Smyrak
>  
> 
> 
> 


Ok, I took a look. Does it mean just replacing %%JAVAJARDIR%% with ${JAVAJARDIR}?

Rebuild the package now in poudriere and that seems to work fine.

Regards,
Ronald.
 
------=_Part_9677_535086113.1728400609858
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: 7bit

<html><head></head><body><br>
<p><strong>Van:</strong> Piotr Smyrak &lt;ps.ports@smyrak.com&gt;<br>
<strong>Datum:</strong> dinsdag, 8 oktober 2024 14:48<br>
<strong>Aan:</strong> ports@freebsd.org<br>
<strong>Onderwerp:</strong> Re: what to do about "FATAL: PLIST_FILES: files cannot contain %%FOO%% variables. Use make variables and logic instead"</p>

<blockquote style="padding-right: 0px; padding-left: 5px; margin-left: 5px; border-left: #000000 2px solid; margin-right: 0px">
<div class="MessageRFC822Viewer" id="P">
<div class="TextPlainViewer" id="P.P">On Tue, 8 Oct 2024 14:34:23 +0200 (CEST)<br>
Ronald Klop &lt;ronald-lists@klop.ws&gt; wrote:<br>
<br>
&gt; I was looking for a change to devel/jna and after running portlint it<br>
&gt; says:<br>
&gt;<br>
&gt; FATAL: PLIST_FILES: files cannot contain %%FOO%% variables. &nbsp;Use make<br>
&gt; variables and logic instead<br>
&gt;<br>
&gt; The lines in the Makefile this is about are:<br>
&gt; PLIST_FILES= &nbsp;&nbsp;&nbsp;%%JAVAJARDIR%%/jna-platform.jar \<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;%%JAVAJARDIR%%/jna.jar<br>
&gt;<br>
&gt; What would be the proper solution for this?<br>
<br>
See x11-fonts/iansui Makefile for an example.<br>
<br>
HTH,<br>
--&nbsp;<br>
&nbsp;Piotr Smyrak<br>
&nbsp;</div>

<hr></div>
</blockquote>
<br>
<br>
Ok, I took a look. Does it mean just replacing %%JAVAJARDIR%% with ${JAVAJARDIR}?<br>
<br>
Rebuild the package now in poudriere and that seems to work fine.<br>
<br>
Regards,<br>
Ronald.<br>
&nbsp;</body></html>
------=_Part_9677_535086113.1728400609858--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1718369388.9678.1728400609900>