Date: Fri, 20 Sep 2002 17:51:09 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: John Baldwin <jhb@FreeBSD.org> Cc: Darren Reed <darrenr@reed.wattle.id.au>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c Message-ID: <17560.1032537069@critter.freebsd.dk> In-Reply-To: Your message of "Fri, 20 Sep 2002 11:40:59 EDT." <XFMail.20020920114059.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <XFMail.20020920114059.jhb@FreeBSD.org>, John Baldwin writes:
>
>On 20-Sep-2002 Darren Reed wrote:
>There is nothing intuitive about
>a function named foo_length() not returning the length of 'foo'.
man 9 mbuf:
[...]
m_length(buf, last)
Return the length of the mbuf chain, and optionally a pointer to
the last mbuf.
[...]
I'm sure there are many arguments sounding from various levels of
moral altitudes about why this function is bad for the mbuf,
architecture, how it spoils the youth and leads to early hair-loss
in developers.
Overriding all these (IMO) is the fact that N (> 3) places had
implemented it in various sundry ways.
That, for me, is plenty reason to make an official library function
to do the job.
The fact that Darren not even bothered to read the commit message,
much less the man page or the code before he jumped in and botched
it up, is no reason to build a historical landmark bikeshed on the
spot where it happened.
Over and out...
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?17560.1032537069>