Date: Sat, 7 Jan 1995 13:00:17 -0800 (PST) From: "Justin T. Gibbs" <gibbs@estienne.CS.Berkeley.EDU> To: dufault@hda.com (Peter Dufault) Cc: freebsd-hackers@freefall.cdrom.com Subject: Re: Commit testing Message-ID: <199501072100.NAA20491@estienne.cs.berkeley.edu> In-Reply-To: <199501071726.MAA08014@hda.com> from "Peter Dufault" at Jan 7, 95 12:26:07 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> > How do committers test things? I want to commit changes to > sys/scsi/* and sys/i386/isa/aha1542.c. (the diffs, if you want to > see them, are on freefall in pub:incoming/sutar7.gz) How do you I've been running sutar6 (plus the resolution of some conflicts with Rod's scsi changes) ever since it was released. I haven't noticed anything unusual. > handle the time between when you've thoroughly tested something > and you then check it into -current? By hoping and watching commit > logs? Well, I usually thoroughly test my code, and when I'm ready to commit it, SUP current and rebuild, do about an hour or so of testing again, and commit. Then I re-sup, merge conflicts, and retest to see if I've left anything out or botched the commit. For future commits, I plan on checking out a brand new copy of the kernel sources (I sup CVS) in this phase since otherwise its hard to tell if you left anything out of the commit. > > And does anyone review changes before they are commited, and > what is that process? I think it depends on what you're doing. In the case of the aic7770 driver, there are very few people that would be able to review my changes. I guess it is more of an ownership kind of thing, but it would be nice to have a real policy on this. > > Peter > > -- > Peter Dufault Real Time Machine Control and Simulation > HD Associates, Inc. Voice: 508 433 6936 > dufault@hda.com Fax: 508 433 5267 > -- Formerly hd@world.std.com. E-mail problems? Tell hdslip@iii.net > -- Justin T. Gibbs ============================================== TCS Instructional Group - Programmer/Analyst 1 Cory | Po | Danube | Volga | Parker | Torus ==============================================
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199501072100.NAA20491>