Date: Wed, 29 Mar 1995 04:01:15 +1000 From: Bruce Evans <bde@zeta.org.au> To: bde@zeta.org.au, charnier@lirmm.fr Cc: hackers@FreeBSD.org Subject: Re: patches for -Wall in sbin Message-ID: <199503281801.EAA30784@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>>Let me handle the patches for fsck. I have been (slowly) checking >>phk's patches for -Wall for it. >> >That code uses functions for writing warning and errors messages, that >-Wall doesn't like. What a pity to not use the 4.4 interface for this >(warnx, errx and al.). There should be warnings for bad args to warnx, etc. too :-). Anything that supports printf-style error messages should be declared as __attribute__((format(printf, m, n))) where `m' is the arg number of the format string and `n' is the arg number of the first vararg. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199503281801.EAA30784>