Date: Sun, 15 Dec 1996 20:53:33 +1100 From: Bruce Evans <bde@zeta.org.au> To: nate@mt.sri.com, peter@spinner.dialix.com Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/boot/rawboot Makefile Message-ID: <199612150953.UAA32173@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>> > Add missing -I so that probe_keyboard.c can find <i386/isa/kbdio.h>. :-( >> > (Why, oh why did this include file end up in isa/ rather than include/ ?) >> >> Because it's supposed to be only used by isa drivers. ;) >> >> Nate > >.. and it wouldn't need to be used if the keyboard IO port definitions >were not ripped out of <machine/cons.h>. The boot code needs to know the They were ripped out of <machine/console.h>. <machine/cons.h> is for the console driver. <machine/console.h> is for syscons ioctls. >port addresses. Those should have stayed in cons.h, the prototypes in kbdio.h >are only useful to users of kbdio.c (probe_keyboard doesn't use kbdio.c). No, the should never have been in any of these files. The ioctls in <machine/console.h> are only useful to applications accessing syscons devices. The keyboard definitions belong in <ic/i8042.h>. They've always been <sys/../i386/isa/ic/i8042.h> (with different names). Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199612150953.UAA32173>