Date: Fri, 7 Feb 1997 19:42:24 -0800 (PST) From: Bill Paul <wpaul> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/scsi scsi_base.c scsi_driver.c scsiconf.c scsiconf.h Message-ID: <199702080342.TAA21190@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
wpaul 97/02/07 19:42:24
Modified: sys/scsi scsi_base.c scsi_driver.c scsiconf.c scsiconf.h
Log:
Make some small tweaks to the messages to clean up some stuff
from last time. Some people have pointed out that there were some odd
side-effects in the changes I made. Two things are different:
- sc_print_addr() will print 'foodev0:' (i.e. sd0:, st0:, cd0:, etc...)
if the device name is known. If it's not known, it'll use a longer
notation. This shortens error messages back to a sane length.
- Added a small function called sc_print_init() to set the sc_printing
flag so that sc_print_addr() will know that we want it to print a
linefeed. Used this in scsi_device_attach() to restore proper carriage
return printing behavior which I broke.
Remaining bogons: the NCR SCSI driver prints out information while the
device-specific attach routine is running with its own linefeeds. This
breaks up the individual messages emitted by the subdriver modules and
causes at least one message to appear on a line by itself without a
device spec prefix. I'm not sure of the correct way to fix this, and
I don't have any NCR SCSI hardware to test with anyway.
There's probably more, but I gather that a rewrite of the SCSI subsystem
is pending anyway, so I'll leave the rest to Those Who Know More About
This Than I (tm).
Revision Changes Path
1.44 +9 -2 src/sys/scsi/scsi_base.c
1.21 +8 -0 src/sys/scsi/scsi_driver.c
1.77 +1 -1 src/sys/scsi/scsiconf.c
1.49 +1 -0 src/sys/scsi/scsiconf.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199702080342.TAA21190>